Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WGET_OPTS to WGET_OPTIONS in build.sh #239

Closed

Conversation

asilichenko
Copy link
Contributor

@asilichenko asilichenko commented Jan 7, 2025

Changed variable name WGET_OPTS to WGET_OPTIONS in the documentation block "Some noteworthy control variables" in make/build.sh.

WGET_OPTIONS is used in the download_using_wget() function in make/build-support/build-common.sh.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/239/head:pull/239
$ git checkout pull/239

Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.org/jtreg.git pull/239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 239

View PR using the GUI difftool:
$ git pr show -t 239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/239.diff

Changed variable name WGET_OPTS to WGET_OPTIONS in the documentation block "Some noteworthy control variables" in build.sh.

WGET_OPTIONS is used in the download_using_wget() function in build-support/build-common.sh.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2025

Hi @asilichenko, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user asilichenko" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@asilichenko
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 20, 2025
@asilichenko
Copy link
Contributor Author

Merged into #238

@asilichenko asilichenko deleted the fix-wget-options-variable branch January 21, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant