Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http client option to disable IPv6 #761

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: add http client option to disable IPv6 #761

merged 1 commit into from
Feb 7, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Feb 6, 2024

  • improve connection re-use
  • add detailed trace events (DNS, TLS, etc)

Looks like this in Tempo: left is a newly established connection, right is a reused connection.

image

@alnr alnr self-assigned this Feb 6, 2024
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

httpx/ssrf.go Show resolved Hide resolved
* improve connection re-use
* add detailed trace events (DNS, TLS, etc)
@alnr alnr requested review from hperl and aeneasr February 7, 2024 13:16
@alnr alnr enabled auto-merge (rebase) February 7, 2024 13:16
@alnr alnr merged commit 041443c into master Feb 7, 2024
8 checks passed
@alnr alnr deleted the alnr/no-ipv6 branch February 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants