-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upin xclim, package health #832
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…vironment dependencies, use newer actions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There are a few really annoying/loud warnings coming from xclim. I've opened an issue to handle one of the worst offenders: Ouranosinc/xclim#1489. A few other warnings coming from xclim have already been dealt with in the master branch and will be muted in v0.46.0. I've tried my best to clean things up here without breaking much. It feels to me a bit easier to maintain the CI and environments now. The same six tests are failing across builds, but I have no idea how to address them (perhaps these will be tackled in #831). The documentation is building with hundreds of warnings; This would definitely need to be fixed in another Pull Request. I need to move on to other projects for the time being, but hopefully this PR helps a bit! |
Getting a core dump now |
One time it worked for maximum deps without a python version https://github.com/pangeo-data/climpred/actions/runs/6678923589/job/18150486165 but failed for the ones with a python version in the name but I don't even see where the one without python version in name is configured ... |
exchange netcdf4 for h5netcdf in env seems to work |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Finally! It took a while but now I resolved all issues and CI passed. |
Fixes #815 ? |
@@ -43,22 +44,20 @@ | |||
) # circumventing esmpy/xesmf installation issues; use conda | |||
# after complete is set, add in test | |||
extras_require["test"] = [ | |||
"netcdf4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be replaced with h5netcdf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally it works with netcdf but I will add a comment here
That's fantastic! I'm away from the office for the next few days, but everything looks good on my end! |
Looks good! Thanks for all your work! |
Description
This PR does the following:
setup.py
metadata (specifies Python3.11 support)--color=yes
and--verbose
topytest
callsnb_black
(unmaintained)To-Do List
Type of change
How Has This Been Tested?
pytest
, if necessary.Checklist (while developing)
References
See: conda-forge/climpred-feedstock#26