Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upin xclim, package health #832

Merged
merged 94 commits into from
Oct 30, 2023
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Oct 3, 2023

Description

This PR does the following:

  • Unpins xclim's version
  • Sorts the environment.yml and the setup.py metadata (specifies Python3.11 support)
  • Adds --color=yes and --verbose to pytest calls
  • Adds a few relevant pre-commit hooks, as well as updates existing versions
  • Removes nb_black (unmaintained)
  • Fixed a few flake8 violations and RuntimeWarnings
  • Employs the mamba-org/setup-micromamba Action across all CI workflows, with caching
  • Cleans up the environment files for all build variants (migrating pip libraries to conda-forge equivalents, sorting alphabetically, pinning versions unilaterally).
  • ReadTheDocs now uses the mambaforge image to make better use of conda
  • @aaronspring: fix tests or silence tests

To-Do List

Type of change

  • Unpin dependencies

How Has This Been Tested?

  • Tests added for pytest, if necessary.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the sphinx documentation, if necessary.
  • Any new functions are added to the API. (See contribution guide)
  • CHANGELOG is updated with reference to this PR.

References

See: conda-forge/climpred-feedstock#26

climpred/__init__.py Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator Author

There are a few really annoying/loud warnings coming from xclim. I've opened an issue to handle one of the worst offenders: Ouranosinc/xclim#1489. A few other warnings coming from xclim have already been dealt with in the master branch and will be muted in v0.46.0.

I've tried my best to clean things up here without breaking much. It feels to me a bit easier to maintain the CI and environments now. The same six tests are failing across builds, but I have no idea how to address them (perhaps these will be tackled in #831).

The documentation is building with hundreds of warnings; This would definitely need to be fixed in another Pull Request.

I need to move on to other projects for the time being, but hopefully this PR helps a bit!

@aaronspring
Copy link
Collaborator

Getting a core dump now

@aaronspring
Copy link
Collaborator

aaronspring commented Oct 28, 2023

One time it worked for maximum deps without a python version https://github.com/pangeo-data/climpred/actions/runs/6678923589/job/18150486165 but failed for the ones with a python version in the name but I don't even see where the one without python version in name is configured ...

@aaronspring
Copy link
Collaborator

exchange netcdf4 for h5netcdf in env seems to work

@aaronspring
Copy link
Collaborator

Finally! It took a while but now I resolved all issues and CI passed.
Any further changes before I merge? @mathause @Zeitsperre

@aaronspring
Copy link
Collaborator

Fixes #815 ?

@@ -43,22 +44,20 @@
) # circumventing esmpy/xesmf installation issues; use conda
# after complete is set, add in test
extras_require["test"] = [
"netcdf4",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be replaced with h5netcdf?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally it works with netcdf but I will add a comment here

@Zeitsperre
Copy link
Collaborator Author

That's fantastic! I'm away from the office for the next few days, but everything looks good on my end!

@mathause
Copy link
Contributor

Looks good! Thanks for all your work!

@aaronspring aaronspring merged commit 38794ed into pangeo-data:main Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file infrastructure software engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants