Support Tree Table in DataView #19
Conversation
fhlavac
requested review from
karelhala,
dlabaj,
Hyperkid123 and
nicolethoen
| <Thead data-ouia-component-id={`${ouiaId}-thead`} {...props}> | ||
| <Tr ouiaId={`${ouiaId}-tr-head`}> | ||
| {onSelect && isSelected && !isTreeTable && <Th key="row-select" screenReaderText='Data selection table header cell' />} | ||
| {columns.map((column, index) => ( |
| const areAllDescendantsSelected = (node: DataViewTrTree) => getDescendants(node).every((n) => isSelected?.(n)); | ||
| const areSomeDescendantsSelected = (node: DataViewTrTree) => getDescendants(node).some((n) => isSelected?.(n)); |
There was a problem hiding this comment.
@Hyperkid123 I'm just not sure what I could use as a dependency for useMemo in these cases
There was a problem hiding this comment.
Whatever changes the outcomes. The iSnodeChecked which is using these might be a better place. Or the getDescendants. There is a lot if iterations happening in general. It can be a touch more efficient.
| } | ||
| }; | ||
|
|
||
| const childRows = |
| <Table isTreeTable aria-label="Data table" ouiaId={ouiaId} {...props}> | ||
| <DataViewTableHeader isTreeTable columns={columns} ouiaId={ouiaId} /> | ||
| <Tbody> | ||
| {renderRows(rows)} |
There was a problem hiding this comment.
I'd store the node(s) into a variable and just use that instead of calling the function.
| const isNodeChecked = (node: DataViewTrTree) => { | ||
| if (areAllDescendantsSelected(node)) { | ||
| return true; | ||
| } | ||
| if (areSomeDescendantsSelected(node)) { | ||
| return null; | ||
| } | ||
| return false; | ||
| }; |
|
@Hyperkid123 made some cleanup. The issues should be resolved now, thanks! |
| ); | ||
| }; | ||
| export const DataViewTable: React.FC<DataViewTableProps> = ({ isTreeTable, ...props }: DataViewTableProps) => ( | ||
| isTreeTable ? (<DataViewTableTree {...(props as DataViewTableTreeProps)} />) : (<DataViewTableBasic {...(props as DataViewTableBasicProps)}/>) |
There was a problem hiding this comment.
You can make the type condition so you won't have to type cast the props.
|
🎉 This PR is included in version 5.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RHCLOUD-34946