Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update client-go and verify all read ts #58054

Merged
merged 29 commits into from
Dec 19, 2024

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Dec 6, 2024

What problem does this PR solve?

Issue Number: ref #57786

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Strengthen timestamp validation checks.

Copy link

ti-chi-bot bot commented Dec 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2024
Copy link

tiprow bot commented Dec 6, 2024

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MyonKeminta MyonKeminta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-tests-checked and removed do-not-merge/needs-tests-checked labels Dec 6, 2024
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta MyonKeminta marked this pull request as ready for review December 6, 2024 08:03
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@MyonKeminta MyonKeminta changed the title *: Update client-go and verify all read ts [DNM] *: Update client-go and verify all read ts Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.9694%. Comparing base (659e3e7) to head (f2d164f).
Report is 169 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58054        +/-   ##
================================================
+ Coverage   73.1844%   74.9694%   +1.7850%     
================================================
  Files          1680       1725        +45     
  Lines        463034     471181      +8147     
================================================
+ Hits         338869     353242     +14373     
+ Misses       103374      95684      -7690     
- Partials      20791      22255      +1464     
Flag Coverage Δ
integration 49.0202% <5.1282%> (?)
unit 72.3243% <87.1794%> (+0.0021%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.7661% <ø> (+15.7763%) ⬆️

Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta MyonKeminta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@MyonKeminta MyonKeminta changed the title [DNM] *: Update client-go and verify all read ts *: Update client-go and verify all read ts Dec 10, 2024
@MyonKeminta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 10, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: MyonKeminta <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 14, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58914.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 14, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #58916.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58918.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 14, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 14, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 14, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 14, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 15, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 16, 2025
ekexium pushed a commit to ekexium/tidb that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.