Chore: Bulge Pinch Filter Deprecations #416
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbazukun123
commented
Feb 8, 2024
bbazukun123
commented
- Add deprecations for the Bulge Pinch filter.
- Use GpuProgram.from and GlProgram.from for caching.
bigtimebuddy
reviewed
Feb 8, 2024
src/bulge-pinch/BulgePinchFilter.ts
Outdated
Comment on lines
11
to
19
| type DeprecatedPointLike = PointData | number[]; | ||
|
|
||
| interface DeprecatedBulgePinchFilterOptions | ||
| { | ||
| center: DeprecatedPointLike; | ||
| radius: number; | ||
| strength: number; | ||
| } | ||
|
|
There was a problem hiding this comment.
Again, I'd argue that we could support number[] publicly, but simply transform it into a PointData in the center setter. Then you don't need all this deprecation code. Just because unforms don't support number[] doesn't mean it's not a valid API choice.
bigtimebuddy
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.