Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bulge Pinch Filter Deprecations #416

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Chore: Bulge Pinch Filter Deprecations #416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b5cf13
Chore: Bulge Pinch Filter Deprecations
bbazukun123 Feb 8, 2024
978c216
Address Feedback
bbazukun123 Feb 13, 2024
639fd8c
Merge branch 'main' into chore-deprecation-bulge-pinch
bigtimebuddy Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/bulge-pinch/BulgePinchFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface BulgePinchFilterOptions
* Offset coordinates to change the position of the center of the circle of effect.
* @default {x:0,y:0}
*/
center?: PointData;
center?: PointData | number[] | number;
/**
* The radius of the circle of effect
* @default 100
Expand Down Expand Up @@ -112,7 +112,20 @@ export class BulgePinchFilter extends Filter
* @default {x:0.5,y:0.5}
*/
get center(): PointData { return this.uniforms.uCenter; }
set center(value: PointData) { this.uniforms.uCenter = value; }
set center(value: PointData | number[] | number)
{
if (typeof value === 'number')
{
value = { x: value, y: value };
}

if (Array.isArray(value))
{
value = { x: value[0], y: value[1] };
}

this.uniforms.uCenter = value;
}

/**
* Sets the center of the effect in normalized screen coords on the `x` axis
Expand Down
Loading