[Morse->Shannon Migration] Scaffold MsgClaimMorsePOKT
#1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
on-chain
15 tasks
bryanchriswhite
force-pushed
the
scaffold/migration/claim
branch
from
2325c35 to
46f2a04
Compare
9 tasks
bryanchriswhite
force-pushed
the
scaffold/migration/claim
branch
from
46f2a04 to
1078e15
Compare
bryanchriswhite
changed the base branch from
issues/1034/scaffold/morse_account_state
to
issues/1034/feat/upload-state
…n_dest_address morse_src_address morse_sign ature --response balance
bryanchriswhite
force-pushed
the
scaffold/migration/claim
branch
from
8749d8f to
c9e4493
Compare
Olshansk
requested changes
Jan 29, 2025
| "github.com/pokt-network/poktroll/x/migration/types" | ||
| ) | ||
|
|
||
| func (k msgServer) ClaimMorsePokt(goCtx context.Context, msg *types.MsgClaimMorsePokt) (*types.MsgClaimMorsePoktResponse, error) { |
|
|
||
| message MsgClaimMorsePoktResponse { | ||
| cosmos.base.v1beta1.Coin balance = 1 [(gogoproto.jsontag) = "balance"]; | ||
| bytes state_hash = 2 [(gogoproto.jsontag) = "state_hash"]; |
There was a problem hiding this comment.
#PUC - unclear how this is being used
| message MsgClaimMorsePokt { | ||
| option (cosmos.msg.v1.signer) = "shannon_dest_address"; | ||
|
|
||
| string shannon_dest_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString", (gogoproto.jsontag) = "shannon_dest_address"]; |
There was a problem hiding this comment.
#PUC w.r.t address types (bech32 or not) and signature types (e.g. ed25519, secp256, etc)
| }, { | ||
| name: "invalid address", | ||
| msg: MsgClaimMorsePokt{ | ||
| MorseSrcAddress: hex.EncodeToString(sample.ConsAddress().Bytes()), |
There was a problem hiding this comment.
Do you mind moving these into local vars and adding some comments to the fact that
Consensus Address == Ed25519 == Morse
Feel free to link to https://www.notion.so/buildwithgrove/Background-Addresses-Key-Schemes-175a36edfff680ff8f23fc7599fd9107?pvs=4
| } | ||
| } | ||
|
|
||
| func (msg *MsgClaimMorsePokt) ValidateBasic() error { |
There was a problem hiding this comment.
Nice!
#PUC onw hat it validates too
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ignite scaffold message claim-morse-pokt --module migration --signer shannon_dest_address morse_src_address morse_signature --response balanceIssue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist