Repo consistency #765
Open
Repo consistency #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerith
reviewed
Oct 23, 2024
yal/tests/test_mainmenu.py
Outdated
| @@ -22,17 +22,25 @@ def build_message_detail( | |||
| id, | |||
| title, | |||
| content, | |||
| tags=[], | |||
| tags=None, | |||
There was a problem hiding this comment.
If these don't specifically need to be lists, we could use empty tuples (()) instead and not have to check for None later.
There was a problem hiding this comment.
We can do this for all the args that were changed from =[] to =None, and we can remove the if ... is None: checks in the body as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the repo consistency work done on this repo.
The main goal is getting all repos to use poetry for package management, and ruff for linting.