Code

Repo consistency#765

Code

Open

fritzbrand wants to merge 26 commits intomainpraekeltfoundation/vaccine-eligibility:mainfrom repo-consistencypraekeltfoundation/vaccine-eligibility:repo-consistencyCopy head branch name to clipboard

+2,332-2,276

Commits

Commits on Oct 15, 2024

• Removed black, isort and flake8, then added ruff

  fritzbrand

  committed
  2e3dedb

  Copy full SHA for 2e3dedb

• Added ignores for all issues reported by ruff

  fritzbrand

  committed
  fdd376e

  Copy full SHA for fdd376e

Commits on Oct 16, 2024

• Loop control variable 'content' not used within loop body

  fritzbrand

  committed
  3b07007

  Copy full SHA for 3b07007

• Possible hardcoded password assigned to argument

  fritzbrand

  committed
  c1cf803

  Copy full SHA for c1cf803

• Unnecessary 'list' comprehension (rewrite as a 'set' comprehension)

  fritzbrand

  committed
  00ff0e7

  Copy full SHA for 00ff0e7

• Use a single 'with' statement with multiple contexts instead of nested 'with' statements

  fritzbrand

  committed
  e69943c

  Copy full SHA for e69943c

• Import block is un-sorted or un-formatted

  fritzbrand

  committed
  6727967

  Copy full SHA for 6727967

• Use 'key in dict' instead of 'key in dict.keys()

  fritzbrand

  committed
  5c32e5f

  Copy full SHA for 5c32e5f

• Dictionary key literal repeated

  fritzbrand

  committed
  7a2996d

  Copy full SHA for 7a2996d

• Use 'is' and 'is not' for type comparisons, or 'isinstance()' for isinstance checks

  fritzbrand

  committed
  e5fb751

  Copy full SHA for e5fb751

• Use ternary operator instead of 'if'-'else'-block

  fritzbrand

  committed
  95ed4db

  Copy full SHA for 95ed4db

• Unnecessary generator (rewrite as a 'set' comprehension)

  fritzbrand

  committed
  357c22a

  Copy full SHA for 357c22a

• It's okay to have hardcoded passwords in tests

  fritzbrand

  committed
  2878459

  Copy full SHA for 2878459

• Do not use mutable data structures for argument defaults

  fritzbrand

  committed
  5b9c368

  Copy full SHA for 5b9c368

• Unnecessary open mode parameters

  fritzbrand

  committed
  515f377

  Copy full SHA for 515f377

• Use a single 'if' statement instead of nested 'if' statements

  fritzbrand

  committed
  7cedbe4

  Copy full SHA for 7cedbe4

• Within an 'except' clause, raise exceptions with 'raise ... from err' or 'raise ... from None'

  fritzbrand

  committed
  afe0705

  Copy full SHA for afe0705

• B005: Using '.strip()' with multi-character strings is misleading

  fritzbrand

  committed
  17fc24b

  Copy full SHA for 17fc24b

• S311 - Standard pseudo-random generators are not suitable for cryptographic purposes

  fritzbrand

  committed
  15d44f1

  Copy full SHA for 15d44f1

• Updated CI config

  fritzbrand

  committed
  1912a68

  Copy full SHA for 1912a68

• Updated CI config

  fritzbrand

  committed
  e4303a3

  Copy full SHA for e4303a3

• Merge branch 'repo-consistency' of https://github.com/praekeltfoundation/vaccine-eligibility into repo-consistency

  fritzbrand

  committed
  cf66ce2

  Copy full SHA for cf66ce2

• Updated CI

  fritzbrand

  committed
  d4564fa

  Copy full SHA for d4564fa

Commits on Oct 24, 2024

• Added ruff-specific rules, and added inline ignores for S105

  fritzbrand

  committed
  0deb82f

  Copy full SHA for 0deb82f

• More ruff updates, and updated readme

  fritzbrand

  committed
  148bf68

  Copy full SHA for 148bf68

• Use empty tuple instead of None

  fritzbrand

  committed
  ac07902

  Copy full SHA for ac07902