Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: TheTradeDesk #3738

Merged
merged 5 commits into from
Aug 6, 2024
Merged

New Adapter: TheTradeDesk #3738

merged 5 commits into from
Aug 6, 2024

Conversation

andre-gielow-ttd
Copy link
Contributor

No description provided.

@andre-gielow-ttd andre-gielow-ttd mentioned this pull request Jun 7, 2024
Merged
8 tasks
@bsardo bsardo changed the title TheTradeDesk adapter New Adapter: TheTradeDesk Jun 10, 2024
@andre-gielow-ttd andre-gielow-ttd force-pushed the master branch 2 times, most recently from 0250830 to 198df0f Compare June 11, 2024 15:22
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5c9ef8e

thetradedesk

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:98:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:118:	MakeBids	94.4%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:156:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:169:	Builder		90.9%
total:										(statements)	96.4%

@przemkaczmarek przemkaczmarek self-requested a review July 29, 2024 16:36
@bsardo bsardo self-assigned this Jul 29, 2024
przemkaczmarek
przemkaczmarek previously approved these changes Jul 31, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1474c4d

thetradedesk

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:98:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:118:	MakeBids	94.4%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:156:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:169:	Builder		91.7%
total:										(statements)	96.5%

bsardo
bsardo reviewed Jul 31, 2024
View reviewed changes
adapters/thetradedesk/thetradedesk.go Show resolved Hide resolved
adapters/thetradedesk/thetradedesktest/exemplary/simple-banner-cookie-uid.json Outdated Show resolved Hide resolved
adapters/thetradedesk/thetradedesktest/supplemental/simple-banner-with-ipv6.json Outdated Show resolved Hide resolved
adapters/thetradedesk/thetradedesktest/exemplary/simple-banner-uid.json Outdated Show resolved Hide resolved
adapters/thetradedesk/thetradedesktest/exemplary/simple-banner-inapp.json Show resolved Hide resolved
adapters/thetradedesk/thetradedesktest/exemplary/simple-banner-multiple-bids.json Show resolved Hide resolved
adapters/thetradedesk/thetradedesk_test.go Outdated Show resolved Hide resolved
adapters/thetradedesk/thetradedesk.go Show resolved Hide resolved
adapters/thetradedesk/thetradedesk.go Show resolved Hide resolved
adapters/thetradedesk/thetradedesk_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 66b9177

thetradedesk

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:173:	Builder		91.7%
total:										(statements)	97.7%

bsardo
bsardo reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the user sync URL.

static/bidder-info/thetradedesk.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c31126e

thetradedesk

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:173:	Builder		91.7%
total:										(statements)	97.7%

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bf2c6be

thetradedesk

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/thetradedesk/thetradedesk.go:173:	Builder		91.7%
total:										(statements)	97.7%

bsardo
bsardo approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit efc1e8b into prebid:master Aug 6, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@gargcreation1992 gargcreation1992 gargcreation1992 left review comments

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

@bsardo bsardo bsardo approved these changes

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
Prebid Server Prioritization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andre-gielow-ttd @muuki88 @bsardo @gargcreation1992 @Sonali-More-Xandr @przemkaczmarek