Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheTradeDesk documentation #5407

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

andre-gielow-ttd
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Prebid Server PR: prebid/prebid-server#3738

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit a18a09a
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/666af5f54221bb0007990293
😎 Deploy Preview https://deploy-preview-5407--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muuki88
Copy link
Contributor

muuki88 commented Jun 13, 2024

You already have your bidder documented ( #3577 ). It should be enough to change the pbs flag to true and add the additional meta data you added in this PR.

@andre-gielow-ttd
Copy link
Contributor Author

You already have your bidder documented ( #3577 ). It should be enough to change the pbs flag to true and add the additional meta data you added in this PR.

That was a good call. I thought I had to match the ID from PBS. I changed the current documents to reflect the new metadata.

@andre-gielow-ttd
Copy link
Contributor Author

@muuki88 I've pushed new changes to just update the existing docs.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be merged, once the prebid server PR is merged 😊

@andre-gielow-ttd
Copy link
Contributor Author

This will be merged, once the prebid server PR is merged 😊

@muuki88 is there a point of contact that I can request a review for the PBS PR?

@muuki88
Copy link
Contributor

muuki88 commented Jun 18, 2024

Are you a prebid member, the slack community otherwise in the PR itself. Prebid is a community driven project and thus can take some time till things are reviewed. Thanks for your understanding 🙏😊

@andre-gielow-ttd
Copy link
Contributor Author

This will be merged, once the prebid server PR is merged 😊

Hey @muuki88 the adapter code has been merged!

@muuki88 muuki88 merged commit c4bae39 into prebid:master Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants