-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align field names for subjects, places #1441
Conversation
Hi @bonniegee -- I took a look and this works great for me in the UI. Nice! In case this helps, I was able to get the tests to pass by changing the selectors here in the tests to "places" and "access_subjects" to reflect your changes in the catalog controller: arclight/spec/features/search_results_spec.rb Line 107 in aebab31
arclight/spec/features/search_results_spec.rb Line 113 in aebab31
|
Thank you so much @marlo-longley! Those changes (and changes to the text itself) led the tests to pass. |
@bonniegee awesome! Good catch on the labels in the tests. If it's possible to rebase this branch to the latest version of |
…n bleed off the screen.
2fe98b8
to
bdfdc8c
Compare
Fixes #1422
"Places" was having the same issue as "access_subjects," so I addressed that as well.