Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align field names for subjects, places #1441

Closed
wants to merge 8 commits into from
Closed

Conversation

bonniegee
Copy link
Contributor

Fixes #1422

"Places" was having the same issue as "access_subjects," so I addressed that as well.

@bonniegee bonniegee marked this pull request as draft December 6, 2023 19:13
@marlo-longley
Copy link
Contributor

marlo-longley commented Dec 13, 2023

Hi @bonniegee -- I took a look and this works great for me in the UI. Nice!

In case this helps, I was able to get the tests to pass by changing the selectors here in the tests to "places" and "access_subjects" to reflect your changes in the catalog controller:

within('.blacklight-place') do

within('.blacklight-subject') do

@bonniegee
Copy link
Contributor Author

Thank you so much @marlo-longley! Those changes (and changes to the text itself) led the tests to pass.

@bonniegee bonniegee marked this pull request as ready for review December 13, 2023 21:42
@marlo-longley
Copy link
Contributor

@bonniegee awesome! Good catch on the labels in the tests.

If it's possible to rebase this branch to the latest version of main (so that this PR only shows your commit), that could make merging easier and I am happy to approve.

@bonniegee bonniegee marked this pull request as draft December 13, 2023 22:49
@bonniegee bonniegee closed this Dec 14, 2023
@bonniegee bonniegee deleted the index-terms-links branch December 14, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creator, Subjects, and Places Links Not Applying Filter on Redirect
4 participants