Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align field names for subjects, places #1441

Closed
wants to merge 8 commits into from
Closed

Align field names for subjects, places #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da797fa
fixes #1422
bonniegee Dec 6, 2023
5a23b9c
Allow autocomplete items to wrap. Otherwise, very long suggestions ca…
lfarrell Nov 28, 2023
b799ca1
Move search form CSS to its own file
lfarrell Dec 6, 2023
8ec6872
altformavail and bioghist now display at the component level
bonniegee Dec 13, 2023
eee05b5
fixed merge conflict with date_range integer issue
gwiedeman Dec 8, 2023
428925a
Allow for indexing and display of multiple extents
bonniegee Dec 13, 2023
bdfdc8c
update tests to include new terms
bonniegee Dec 13, 2023
101367c
align with main
bonniegee Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/arclight/group_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@
</div>

<%= helpers.render_document_index @group.docs %>
</div>
</div>
4 changes: 2 additions & 2 deletions lib/generators/arclight/templates/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ class CatalogController < ApplicationController
config.add_facet_field 'level', field: 'level_ssim', limit: 10
config.add_facet_field 'names', field: 'names_ssim', limit: 10
config.add_facet_field 'repository', field: 'repository_ssim', limit: 10
config.add_facet_field 'place', field: 'geogname_ssim', limit: 10
config.add_facet_field 'subject', field: 'access_subjects_ssim', limit: 10
config.add_facet_field 'places', field: 'geogname_ssim', limit: 10
config.add_facet_field 'access_subjects', field: 'access_subjects_ssim', limit: 10

# Have BL send all facet field names to Solr, which has been the default
# previously. Simply remove these lines if you'd rather use Solr request
Expand Down
8 changes: 4 additions & 4 deletions spec/features/search_results_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,14 @@
expect(page).to have_css('li .facet-label', text: 'National Library of Medicine. History of Medicine Division', visible: :hidden)
end

within('.blacklight-place') do
expect(page).to have_css('h3 button', text: 'Place')
within('.blacklight-places') do
expect(page).to have_css('h3 button', text: 'Places')
expect(page).to have_css('li .facet-label', text: 'Mindanao Island (Philippines)', visible: :hidden)
expect(page).to have_css('li .facet-label', text: 'Yosemite National Park (Calif.)', visible: :hidden)
end

within('.blacklight-subject') do
expect(page).to have_css('h3 button', text: 'Subject')
within('.blacklight-access_subjects') do
expect(page).to have_css('h3 button', text: 'Subjects')
expect(page).to have_css('li .facet-label', text: 'Slides.', visible: :hidden)
expect(page).to have_css('li .facet-label', text: 'Fraternizing', visible: :hidden)
end
Expand Down