Updated nikic/php-parser to 4.x. #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweingarten
force-pushed
the
php-parser-4
branch
from
c3728a8 to
7c69a23
Compare
aweingarten
force-pushed
the
php-parser-4
branch
from
7c69a23 to
4e1e076
Compare
hugovk
approved these changes
Feb 11, 2019
|
Would be great to get this updated, the dependency to |
|
I don't really know why travis is not executing tests in this branch atm but the tests are failing. I also created a PR some time ago to get to next major version but never really finished it |
jakzal
suggested changes
May 13, 2019
| @@ -15,7 +15,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.5.9 || ^7.0", | |||
There was a problem hiding this comment.
Since tests no longer run on <=7.1, the minimum PHP version should be bumped as well.
| @@ -8,11 +8,7 @@ cache: | |||
|
|
|||
| matrix: | |||
| include: | |||
| - php: 5.5 | |||
There was a problem hiding this comment.
7.2 and 7.3 should be added to the matrix.
|
Duplicate of #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.