Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UnitInput value not updating #12420

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 29, 2024

Summary

Fixes #12412
Fixes #12416

UnitInput controls with value set as v-model.number didn't get updated correctly during migration. If control doesn't have corresponding @input event, value was not getting updated.

Occurred changes and/or fixed issues

N/A

Technical notes summary

N/A

Areas or cases that should be tested

See linked issues for reproduction steps

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

momesgin
momesgin previously approved these changes Oct 29, 2024
@momesgin momesgin dismissed their stale review October 29, 2024 23:31

new code changes coming

@richard-cox
Copy link
Member

@eva-vashkevich this fixes notation needs to be per issue, i've split them up to ensure the issue state's automatically get update

@richard-cox richard-cox self-requested a review October 30, 2024 12:52
@@ -326,7 +326,7 @@ export default {
</div>
<div class="col span-6">
<UnitInput
v-model.number="scheduledScanConfig.retentionCount"
v-model:value="scheduledScanConfig.retentionCount"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be the same for all instances of v-model.number, i'll create a ticket to investigate

  • shell/components/form/Ports.vue
  • shell/components/form/ServicePorts.vue
  • shell/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue

@nwmac nwmac merged commit 190f486 into rancher:master Oct 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants