Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce E2E setup and tests in GKE #256

Merged
merged 11 commits into from
Jan 8, 2024
Merged

✨ Introduce E2E setup and tests in GKE #256

merged 11 commits into from
Jan 8, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Jan 5, 2024 •
edited
Loading

What this PR does / why we need it:
This PR introduces:

  • an E2E setup and adds E2E tests to the repository
  • full instructions (root README.md) on how to run tests locally.
  • new Makefile targets for E2E
  • daily running e2e tests GH workflow to test an operator with the latest rancher

Which issue(s) this PR fixes
Fixes: #97
Fixes: #100

Special notes for your reviewer:

  1. I already created the GKE_CREDENTIALS secret in the repo, once this PR is merged, we should be able to test the E2E GHA workflows running.
  2. I ran the E2E tests locally following the notes in the README.md from this patch and GKE cluster came up successfully in GCP.

image
image

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@furkatgofurov7 furkatgofurov7 added the kind/enhancement New feature or request label Jan 5, 2024
@furkatgofurov7 furkatgofurov7 self-assigned this Jan 5, 2024
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner January 5, 2024 10:39
salasberryfin
salasberryfin previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mjura
mjura previously approved these changes Jan 8, 2024
View reviewed changes
@mjura
Copy link
Contributor

mjura commented Jan 8, 2024

can you please rebase ?

@furkatgofurov7
Add e2e Makefile targets
830b904 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add artifacts to gitignore
e1387fc 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add e2e github workflow
45b0f7c 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add kind cluster setup script
4b55eec 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Import needed dependencies
2d2577a 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add e2e tests setup
3cd2f0b 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add cluster template to e2e
8e31c69 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add basic e2e test
b5eaefa 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Add Makefile target to deploy an operator
22a6864 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Update README and add e2e test notes
5cd02c8 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7
Update update-rancher GH workflow names to match with notes
4ceae96 
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 furkatgofurov7 dismissed stale reviews from mjura and salasberryfin via 4ceae96 January 8, 2024 16:34
@mjura mjura merged commit fe8ad63 into rancher:main Jan 8, 2024
7 checks passed
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jan 10, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjura mjura mjura approved these changes

@salasberryfin salasberryfin salasberryfin left review comments

Assignees

@furkatgofurov7 furkatgofurov7

Labels
kind/enhancement New feature or request
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
No milestone
3 participants
@furkatgofurov7 @mjura @salasberryfin