-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce libcuml wheels #6199
introduce libcuml wheels #6199
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
On this PR, I see:
Those times do not include time spent waiting for a runner to pick up the jobs... that's all time occupying a GPU runner. I see that happening on other PRs too, for example this in-progress build from #6238: https://github.com/rapidsai/cuml/actions/runs/12931830455/job/36069533961 Not sure if #6247 is the root cause... that refers to a "hang" but doesn't have other details. |
Contributes to rapidsai/build-planning#33 Adjusts `rapids-build-utils` manifest for release 25.02 to account for the introduction of new `libcuml` wheels (rapidsai/cuml#6199). ## Notes for Reviewers This shouldn't be merged still pointing at my forks. Plan: 1. merge #440, then update this branch 2. see CI pass here 3. see all CI except devcontainers pass on rapidsai/cuml#6199 4. point this PR back at upstream and admin-merge it 5. re-run devcontainers CI on rapidsai/cuml#6199 and see it pass
Sweet everything is finally passing here! |
I think this is ready! |
/merge |
Proposes updating the metadata here to account for new wheels added in the 25.02 release cycle. This shouldn't be merged until all of these are: * [x] `libcugraph` (rapidsai/cugraph#4804) * [x] `libcuml` (rapidsai/cuml#6199 ) * [x] `libcuvs` (rapidsai/cuvs#594)
Replaces #6006, contributes to rapidsai/build-planning#33.
Proposes packaging
libcuml
as a wheel, which is then re-used bycuml-cu{11,12}
wheels.Notes for Reviewers
Benefits of these changes
Wheel contents
libcuml
:libcuml++.so
(shared library) and its headerslibcumlprims_mg.so
(shared library) and its headersfmt
)cuml
:cuml
Python / Cython code and compiled Cython extensionsDependency Flows
In short....
libcuml
containslibcuml.so
andlibcumlprims_mg.so
dynamic libraries and the headers to link against them.libcugraph
wheels as a build dependency.libcuml.load_library()
.For more details and some flowcharts, see rapidsai/build-planning#33 (comment)
Size changes (CUDA 12, Python 3.12, x86_64)
libcuml
cuml
NOTES: size = compressed, "before" = 2025-01-22 nightlies
how I calculated those (click me)
How I tested this
These other PRs: