Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce cmake-format and cmake-lint, other small packaging changes #353

Closed
wants to merge 6 commits into from

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#136

Proposes using cmake-format and cmake-lint here to standardize CMake code style, similar to the way that other RAPIDS libraries do.

The new files cpp/scripts/run-cmake-format.sh and cpp/cmake/config.json were borrowed and then lightly adapted from cuDF (code link).

All changes in CMakeLists.txt and .cmake files here were made automatically by cmake-format, like this:

FORMAT_FILE_URL="https://raw.githubusercontent.com/rapidsai/rapids-cmake/branch-25.02/cmake-format-rapids-cmake.json"
export RAPIDS_CMAKE_FORMAT_FILE=/tmp/rapids_cmake_ci/cmake-formats-rapids-cmake.json
mkdir -p $(dirname ${RAPIDS_CMAKE_FORMAT_FILE})
wget -O ${RAPIDS_CMAKE_FORMAT_FILE} ${FORMAT_FILE_URL}

Notes for Reviewers

How I tested this

git fetch upstream --tags
./ci/release/update-version.sh '0.43.00'
git grep -E '25\.2'
git grep -E '25\.02'
git grep -E '0\.42'

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 23, 2025

This comment was marked as resolved.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: enforce cmake-format and cmake-lint, other small packaging changes enforce cmake-format and cmake-lint, other small packaging changes Jan 23, 2025
@jameslamb jameslamb marked this pull request as ready for review January 23, 2025 20:22
@jameslamb jameslamb requested review from a team as code owners January 23, 2025 20:22
@jameslamb jameslamb requested a review from raydouglass January 23, 2025 20:22
@jameslamb jameslamb changed the title enforce cmake-format and cmake-lint, other small packaging changes fix update-version.sh Jan 24, 2025
@jameslamb
Copy link
Member Author

closing this, as the only substantive change it had was related to CMake formatting, and we're going to pursue a better long-term approach than what this PR had been proposing: rapidsai/cugraph#4889 (comment)

Sorry for the noise.

@jameslamb jameslamb closed this Jan 24, 2025
@jameslamb jameslamb changed the title fix update-version.sh enforce cmake-format and cmake-lint, other small packaging changes Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant