Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aria-labels for close buttons on dialog and drawer #233

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: accessibility update - adding aria-labels

What is the current behavior?

Issue Number: N/A
Close buttons but dialog and drawers just shows x instead of something that's more useful for screen readers

What is the new behavior?

Close button for dialogs and drawers now have a more explicit aria-label

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:41pm

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit bc72998
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/667469b84b8ccf00080547b4
😎 Deploy Preview https://deploy-preview-233--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steppy452 steppy452 marked this pull request as ready for review June 20, 2024 17:49
@steppy452 steppy452 requested a review from amcdnl June 20, 2024 17:49
@amcdnl amcdnl merged commit 22c44f1 into master Jun 20, 2024
7 checks passed
@amcdnl amcdnl deleted the syang/dialog-drawer-close-aria branch June 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants