PR for vision branch - working note detection and new drive method. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on crane on Thursday :)
SJJCoding
requested review from
jamesdooley4,
bobtseattle,
kirbt and
KangarooKoala
jamesdooley4
requested changes
Feb 22, 2024
src/main/java/frc/team2412/robot/commands/drivebase/DriveCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/drivebase/DriveCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
jbko6
reviewed
Feb 23, 2024
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/drivebase/DriveCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/DrivebaseSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/DrivebaseSubsystem.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Joseph Eng <[email protected]>
…impleDrive(), driving towards note is done in DriveToNoteCommand now
…added PR suggestion
TAKBS2412
reviewed
Feb 25, 2024
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
jamesdooley4
requested changes
Feb 27, 2024
src/main/java/frc/team2412/robot/commands/drivebase/DriveToNoteCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/drivebase/DriveToNoteCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
|
Overall, this is looking a lot better & I'm hoping to be able to see it in use where the robot just automatically finds & grabs the note in front of it. |
jamesdooley4
requested changes
Mar 15, 2024
src/main/java/frc/team2412/robot/subsystems/LimelightSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/drivebase/DriveToNoteCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/drivebase/DriveToNoteCommand.java
Outdated
Show resolved
Hide resolved
|
ready to merge fr fr |
src/main/java/frc/team2412/robot/commands/drivebase/DriveToNoteCommand.java
Show resolved
Hide resolved
jamesdooley4
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.