Shuffleboard Debug Mode vs Non Debug Mode #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAKBS2412
reviewed
Mar 1, 2024
src/main/java/frc/team2412/robot/subsystems/IntakeSubsystem.java
Outdated
Show resolved
Hide resolved
bobtseattle
previously requested changes
Mar 1, 2024
src/main/java/frc/team2412/robot/subsystems/LauncherSubsystem.java
Outdated
Show resolved
Hide resolved
This reverts commit dc53f30.
TAKBS2412
previously approved these changes
Mar 18, 2024
|
Approved (pending formatting issues). |
Comment on lines
+280
to
+283
| Shuffleboard.getTab("Launcher") | ||
| .addDouble("Bottom FlyWheel Temp", () -> launcherBottomMotor.getMotorTemperature()); | ||
| Shuffleboard.getTab("Launcher") | ||
| .addDouble("Top FlyWheel Temp", () -> launcherTopMotor.getMotorTemperature()); |
There was a problem hiding this comment.
Have we tested the placement of these? Bottom previously had .withPosition(0, 3) and .withSize(2, 1) and top previously had .withPosition(2, 3) and .withSize(2, 1), but without those I'm worried they will be assigned a spot that overlaps with something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs more or less depending whether or not debug mode is true