Update dockerfile to use a rootless user #837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelpontetto
force-pushed
the
update-dockerfile-to-use-a-rootless-user
branch
from
7d4b7b0 to
254e743
Compare
axelpontetto
requested review from
a team,
andresg4,
PerezIgnacio and
JulianPasquale
| RUN ln -s /usr/lib/*-linux-gnu/libjemalloc.so.2 /usr/lib/libjemalloc.so.2 | ||
| USER $USERNAME |
There was a problem hiding this comment.
Have you tried moving this line up? I assume if we login using this username before running all the copy, we wouldn't need to specify the owner in the command
There was a problem hiding this comment.
Yes, I already tried that. Not sure if there is another workaround.
| @@ -61,19 +61,32 @@ RUN apt-get update -qq && \ | |||
| apt-get install --no-install-recommends -y curl libpq-dev libvips libjemalloc2 && \ | |||
| apt-get clean | |||
|
|
|||
| ENV USERNAME rails_api_base | |||
There was a problem hiding this comment.
Maybe this way we won't need to change if for all the projects 🙂
Suggested change
| ENV USERNAME rails_api_base | |
| ENV USERNAME rails |
Comment on lines
+64
to
+66
| ENV USERNAME rails_api_base | ||
| ENV USER_UID 1000 | ||
| ENV USER_GID 1000 |
There was a problem hiding this comment.
Should we use ENV or ARG here? 🤔 https://docs.docker.com/build/building/variables/
There was a problem hiding this comment.
At first I tried using ARG but I remember I had some issues with that. I will take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board:
Description:
Notes:
Tasks:
Risk:
Preview: