-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile to use a rootless user #837
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,19 +61,32 @@ RUN apt-get update -qq && \ | |
apt-get install --no-install-recommends -y curl libpq-dev libvips libjemalloc2 && \ | ||
apt-get clean | ||
|
||
ENV USERNAME rails_api_base | ||
ENV USER_UID 1000 | ||
ENV USER_GID 1000 | ||
Comment on lines
+64
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At first I tried using ARG but I remember I had some issues with that. I will take another look. |
||
|
||
# Create a rootless user. | ||
RUN groupadd --gid $USER_GID $USERNAME && \ | ||
useradd --uid $USER_UID --gid $USER_GID -m $USERNAME | ||
|
||
# Create app directory. | ||
RUN mkdir -p $APP_HOME | ||
RUN mkdir -p $APP_HOME && chown -R $USERNAME:$USERNAME $APP_HOME && chmod -R 700 $APP_HOME | ||
|
||
# Change to the rootless user. | ||
USER $USERNAME | ||
|
||
# Setup work directory. | ||
WORKDIR $APP_HOME | ||
|
||
# Copy everything from the builder image | ||
COPY --link . . | ||
COPY --from=builder $APP_HOME/public/ $APP_HOME/public/ | ||
COPY --from=builder $APP_HOME/tmp/ $APP_HOME/tmp/ | ||
COPY --from=builder $APP_HOME/vendor/ $APP_HOME/vendor/ | ||
COPY --link --chown=$USERNAME:$USERNAME --chmod=700 . . | ||
COPY --from=builder --chown=$USERNAME:$USERNAME --chmod=700 $APP_HOME/public/ $APP_HOME/public/ | ||
COPY --from=builder --chown=$USERNAME:$USERNAME --chmod=700 $APP_HOME/tmp/ $APP_HOME/tmp/ | ||
COPY --from=builder --chown=$USERNAME:$USERNAME --chmod=700 $APP_HOME/vendor/ $APP_HOME/vendor/ | ||
|
||
USER root | ||
RUN ln -s /usr/lib/*-linux-gnu/libjemalloc.so.2 /usr/lib/libjemalloc.so.2 | ||
USER $USERNAME | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you tried moving this line up? I assume if we login using this username before running all the copy, we wouldn't need to specify the owner in the command There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I already tried that. Not sure if there is another workaround. |
||
|
||
# Deployment options | ||
ENV RAILS_LOG_TO_STDOUT true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this way we won't need to change if for all the projects 🙂