Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Versioning pickles #204

Open
wants to merge 1 commit into
base: 0.9.x
Choose a base branch
from
Open

Versioning pickles #204

wants to merge 1 commit into from

Conversation

heathermiller
Copy link
Member

No description provided.

@heathermiller
Copy link
Member Author

This is open for discussion. Also FYI @dzufferey (we're touching the pickle format here)

// read format version and check for mismatch
val v = nextByte()
if (v != format.version)
throw new Exception(s"Incompatible pickle format version: read version $v, expected version ${format.version}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw PicklingException instead?

@heathermiller heathermiller self-assigned this Oct 13, 2014
@phaller phaller added this to the 0.10.0 Final milestone Oct 23, 2014
@heathermiller
Copy link
Member Author

Note to self: repoint at 0.10.0

@heathermiller
Copy link
Member Author

For some reason this segfaults for me locally...

@@ -28,6 +29,7 @@ trait PBuilder extends Hintable {

trait PReader extends Hintable {
def mirror: Mirror
def beginPickle(): PReader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no endPickle?

@jasonalaw
Copy link

@heathermiller I saw this pull request and got very excited. Is this an answer to schema evolution with Scala Pickling? I'm very intrigued by Scala Pickling, but I can't jump in until I have some way to evolve my pickled and persisted data structures.

@eed3si9n
Copy link
Member

We should look into implementing versioning on 0.11 branch.

@heathermiller
Copy link
Member Author

Agreed. Although one thing that's happening here is that people are merging the idea of serialization with schema evolution... I'm not sure these concepts should be merged into one. It requires a pretty fundamental design rethink.

@jsuereth
Copy link
Contributor

+1. I think pickling (serialization) shoudl enable schema and schema evolution. NOT be the schema/schema evolution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants