This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Versioning pickles #204
Open
heathermiller
wants to merge
1
commit into
0.9.x
Choose a base branch
from
pickle-versioning
base: 0.9.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Versioning pickles #204
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,10 +50,25 @@ package binary { | |
|
||
private var output: ArrayOutput[Byte] = out | ||
|
||
private var writeVersion = false | ||
|
||
@inline private[this] def mkOutput(knownSize: Int): Unit = | ||
if (output == null) | ||
if (output == null) { | ||
output = if (knownSize != -1) new ByteArrayOutput(knownSize) | ||
else new ByteArrayBufferOutput | ||
if (writeVersion) { | ||
writeVersion = false | ||
Util.encodeByte(output, format.version.asInstanceOf[Byte]) | ||
} | ||
} else if (writeVersion) { | ||
writeVersion = false | ||
Util.encodeByte(output, format.version.asInstanceOf[Byte]) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can avoid code duplication in this case. |
||
|
||
def beginPickle(): PBuilder = { | ||
writeVersion = true | ||
this | ||
} | ||
|
||
@inline def beginEntry(picklee: Any): PBuilder = withHints { hints => | ||
mkOutput(hints.knownSize) | ||
|
@@ -197,6 +212,14 @@ package binary { | |
|
||
var gla: Option[Byte] = None | ||
|
||
def beginPickle(): PReader = { | ||
// read format version and check for mismatch | ||
val v = nextByte() | ||
if (v != format.version) | ||
throw new Exception(s"Incompatible pickle format version: read version $v, expected version ${format.version}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Throw |
||
this | ||
} | ||
|
||
def beginEntryNoTag(): String = | ||
beginEntryNoTagDebug(false) | ||
|
||
|
@@ -427,6 +450,15 @@ package binary { | |
|
||
private var pos = 0 | ||
|
||
def beginPickle(): PReader = { | ||
// read format version and check for mismatch | ||
val v = arr(pos) | ||
pos += 1 | ||
if (v != format.version) | ||
throw new Exception(s"Incompatible pickle format version: read version $v, expected version ${format.version}") | ||
this | ||
} | ||
|
||
def beginEntryNoTag(): String = | ||
beginEntryNoTagDebug(false) | ||
|
||
|
@@ -572,6 +604,9 @@ package binary { | |
class BinaryPickleFormat extends PickleFormat with Constants { | ||
type PickleType = BinaryPickle | ||
type OutputType = ArrayOutput[Byte] | ||
|
||
val version = 2 | ||
|
||
def createBuilder() = new BinaryPickleBuilder(this, null) | ||
def createBuilder(out: ArrayOutput[Byte]): PBuilder = new BinaryPickleBuilder(this, out) | ||
def createReader(pickle: PickleType, mirror: Mirror) = pickle.createReader(mirror, this) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no endPickle?