Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the /training page to include lightbend data #924

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

dylanowen
Copy link
Contributor

Fixes: #921

I moved the training data to it's own json file so we're not loading it for all pages that use functions.js

I also refactored the training functions to work for both the front page and the /training page.

Follow up work: #923 - support for On Demand training

@SethTisue
Copy link
Member

is there a reviewer out there who understands this stuff, at least a little, and could take a look?

@dylanowen
Copy link
Contributor Author

By the way, @SethTisue I enjoyed your talk "You Are A Scala Contributor" at Scala Days. It's what inspired me to start picking up issues 😄

@SethTisue
Copy link
Member

thanks for letting me know, that warms my heart!

@SethTisue
Copy link
Member

I tried previewing this locally but the training page was still blank. otoh, I think I recall that the training stuff never worked in local runs...? not 100% sure

I'm going to go ahead and hit merge and let's just see...

@SethTisue SethTisue merged commit 63a4514 into scala:master Jul 11, 2018
@SethTisue
Copy link
Member

hmm, https://www.scala-lang.org/training/ is still blank...

@dylanowen
Copy link
Contributor Author

Yeah, I believe local runs don't work for training, since the php scripts aren't running (as far as I can see). For development I just served up the json from a local endpoint.

https://www.scala-lang.org/training/ works for me, but has a bit of a lag. Are there any errors in your console?

Maybe we could ditch the php proxying if we could convince the owner of https://www.lightbend.com/subscription/training.json to add some cors response headers?

@dylanowen dylanowen deleted the issue/921 branch July 12, 2018 16:03
@SethTisue
Copy link
Member

https://www.scala-lang.org/training/ works for me, but has a bit of a lag

oh working now, maybe I just closed the tab too quickly last time

🎉

thank you for this

@SethTisue
Copy link
Member

Maybe we could ditch the php proxying if we could convince the owner of https://www.lightbend.com/subscription/training.json to add some cors response headers?

we have an internal ticket on this at https://github.com/lightbend/lightbend.com/issues/1158 (private link) that has now been open for 2.5 years. I pinged again just now

@SethTisue
Copy link
Member

https://twitter.com/scala_lang/status/1017444578771660801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants