Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set posfilter files to no longer load when --from-cache set #302

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

johnbdesanto
Copy link
Collaborator

This is a one-line fix that solves an issue where setting the "--from-cache" flag would not prevent gnatss from loading input files declared in the posfilter mode of the config file. Since some of these files are large (INSPVAA and INSSTDEVA files can be 10s of Gb) this saves a noticeable amount of processing time when --from-cache is set.

The actual functionality of gnatss when --from-cache is declared is not affected since it only runs the solver. Posfilter operations are not performed in this case.

Gnatss can still be run in posfilter mode when --from-cache is not declared, either by declaring --posfilter or by default.

@johnbdesanto johnbdesanto changed the title Bug: Set posfilter files to no longer load when --from-cache set fix: Set posfilter files to no longer load when --from-cache set Aug 20, 2024
@johnbdesanto johnbdesanto requested a review from lsetiawan August 20, 2024 16:57
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.38%. Comparing base (d028023) to head (2cf86da).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   76.31%   76.38%   +0.06%     
==========================================
  Files          29       29              
  Lines        1786     1791       +5     
==========================================
+ Hits         1363     1368       +5     
  Misses        423      423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I like the tiny change and big difference kind of PRs! 🥳 You'll probably need to merge #301 first then this PR

@johnbdesanto johnbdesanto merged commit 904102c into seafloor-geodesy:main Aug 21, 2024
6 checks passed
@johnbdesanto johnbdesanto deleted the update_io branch August 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants