Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3423 Add Lua as Compile Target in Viewer Script Editor #3467

Open
wants to merge 1 commit into
base: project/lua
Choose a base branch
from
Open

#3423 Add Lua as Compile Target in Viewer Script Editor #3467

wants to merge 1 commit into from
+324 −317

Conversation

LLGuru
Copy link
Contributor

@LLGuru LLGuru commented Jan 23, 2025 •
edited
Loading

Replace checkbox Mono with combobox Language

The requested layout (wireframe):
image

The proposed implementation:
image

See https://github.com/secondlife/server/pull/1676 as a linked change

@LLGuru LLGuru marked this pull request as ready for review January 24, 2025 01:47
@LLGuru LLGuru requested a review from akleshchev January 24, 2025 10:13
@LLGuru LLGuru mentioned this pull request Jan 24, 2025
Open
2 tasks
@akleshchev akleshchev requested review from nat-goodspeed and removed request for akleshchev January 24, 2025 11:50
maxim-productengine
maxim-productengine approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@maxim-productengine maxim-productengine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if formatting llstartup is worthwhile.
But otherwise looks good.

@akleshchev akleshchev requested a review from vir-linden January 24, 2025 18:23
vir-linden
vir-linden requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@vir-linden vir-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for near-term release it shouldn't be going to develop. There is no time frame for getting develop released.

@LLGuru LLGuru force-pushed the guru/viewer-3423-add-lua-as-compile-target branch from 72ffd66 to 3be582a Compare January 24, 2025 22:57
@LLGuru LLGuru force-pushed the guru/viewer-3423-add-lua-as-compile-target branch from 3be582a to 7f88aed Compare January 25, 2025 02:03
@LLGuru LLGuru changed the base branch from develop to project/lua January 25, 2025 02:04
@LLGuru LLGuru requested a review from vir-linden January 25, 2025 02:05
@marchcat marchcat self-requested a review January 28, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxim-productengine maxim-productengine maxim-productengine approved these changes

@nat-goodspeed nat-goodspeed Awaiting requested review from nat-goodspeed

@vir-linden vir-linden Awaiting requested review from vir-linden

@marchcat marchcat Awaiting requested review from marchcat

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
c/cpp llmessage llui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LLGuru @vir-linden @maxim-productengine