Initial path structure proposal #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuel-Wiest
approved these changes
Jun 25, 2024
|
My concern is separating the composed models from the generated ones may make it hard to track which model generates which. Somehow we should make this link explicit. We can for example generate the comments about how the model is generated when possible, add We should discuss this in person to go over potential issues and desired structure to come up with a reasonable solution. We should also add documentation about this with this PR, perhaps. |
minhnh
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one issue we have here is a combination of manually-specified and generated models. Perhaps these shouldn't be mixed, and we should have a separate repository for generated artefacts (perhaps particularly the ROS ones).