Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Useless ref-index.so #21

Closed
jtxa opened this issue Nov 3, 2022 · 6 comments · Fixed by #22
Closed

doc: Useless ref-index.so #21

jtxa opened this issue Nov 3, 2022 · 6 comments · Fixed by #22

Comments

@jtxa
Copy link
Contributor

jtxa commented Nov 3, 2022

The content of the generated ref-index.so is not used.
Even if it's empty, the PDF is identical: same size, same text content, just some bytes are different at the end, some of them being a unique identifier
This is a regression of version 1.65.

Found a small extra problem: the last content page in the PDF has number 1000. But this was introduced a long time age (I checked 1.50 and it was already there)

@jtxa jtxa mentioned this issue Nov 3, 2022
@sierrafoxtrot sierrafoxtrot linked a pull request Nov 3, 2022 that will close this issue
@sierrafoxtrot
Copy link
Owner

I've removed ref_index.so. Page 1000 looks like a weekend job though

@jtxa
Copy link
Contributor Author

jtxa commented Nov 3, 2022

Just to make sure, that my issue was understood correctly (I should have added a few sentences more):
The index has no effect today, but in v1.64 it really appended an index (or so called Table of Contents).

If the removal of the index in v1.65 was on purpose, then removing the script completely is the right solution.

@marcows
Copy link
Contributor

marcows commented Nov 3, 2022

See also comments in 4ae29d8

@jtxa
Copy link
Contributor Author

jtxa commented Nov 3, 2022

Yes, that's about the same topic.
So the first page of the index is now at page 3 (a good position), and the rest is missing,

I don't how useful the index is at all, for printed books yes, but today....? Especially as these PDFs have no hyperlinks on page numbers.

@marcows
Copy link
Contributor

marcows commented Nov 4, 2022

I don't how useful the index is at all

See short discussion about this at #11 (comment)

marcows added a commit to marcows/srecord that referenced this issue Nov 4, 2022
The permuted index had been removed in commit 4ae29d8 ("Remove
secondary index from reference manual. Remove Warnings.", 2022-10-28)
and further cleaned up in commit ad1d6f3 ("Remove vestigal
ref_index.so (sierrafoxtrot#22)", 2022-11-04).

See also issue sierrafoxtrot#21.
@sierrafoxtrot
Copy link
Owner

I don't see any harm leaving it it and believe it or not, I actually do have a use for the printed copy (although I'm probably in the minority). Hyperlinks would be a nice addition though. I'll look into how that might be done.

sierrafoxtrot pushed a commit that referenced this issue Nov 4, 2022
The permuted index had been removed in commit 4ae29d8 ("Remove
secondary index from reference manual. Remove Warnings.", 2022-10-28)
and further cleaned up in commit ad1d6f3 ("Remove vestigal
ref_index.so (#22)", 2022-11-04).

See also issue #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants