Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update - Mainly for discv5 update #6834

Closed
wants to merge 3 commits into from

Conversation

AgeManning
Copy link
Member

@AgeManning AgeManning commented Jan 22, 2025

There has been a minor update to discv5.

This PR does a cargo update to update all of lighthouse dependencies, including discv5.

Note that this PR updates lighthouse MSRV to 1.82 as netlink-proto and alloy-* crates use later features.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Jan 22, 2025
@michaelsproul michaelsproul added the backwards-incompat Backwards-incompatible API change label Jan 22, 2025
@michaelsproul
Copy link
Member

Flagging as backwards-incompat so we mention the MSRV increase in the release notes 👍

@michaelsproul michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Jan 22, 2025
@AgeManning AgeManning mentioned this pull request Jan 22, 2025
@@ -1557,9 +1557,9 @@ dependencies = [

[[package]]
name = "crate_crypto_internal_eth_kzg_bls12_381"
version = "0.5.1"
version = "0.5.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think this is the issue. Idk why cargo update is updating this when we have a precise version constraint in the Cargo.toml introduced in https://github.com/sigp/lighthouse/pull/6608/files.

@michaelsproul
Copy link
Member

Closing in favour of fix here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change ready-for-review The code is ready for review v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants