-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo update without rust_eth_kzg
#6848
Conversation
rust_eth_kzg
Ok, this will need the MSRV bump. This is a bit naughty, because the alloy deps shouldn't be bumping MSRV on patch releases. |
MSRV bump is fine, but I've asked about Alloy's policy here just so we know how to handle this going forward: |
@@ -1,4 +1,4 @@ | |||
FROM rust:1.80.0-bullseye AS builder | |||
FROM rust:1.84.0-bullseye AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also bump the version in lcli
too?
Line 4 in 96b00ef
FROM rust:1.80.0-bullseye AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I thought of this and then forgot to do it 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just added a minor comment to update lcli
Dockerfile as well.
Marking this as backwards-incompat
due to MSRV update.
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed Changes
Update cargo dependencies while keeping
rust_eth_kzg
pinned to0.5.1
due to the regression described in:The changes from that PR were not sufficient to actually pin the dependencies of
rust_eth_kzg
, because the dependencies from the workspace Cargo.toml file were not being used anywhere. To fix this, I've added them as explicit dependencies incrypto/kzg/Cargo.toml
. With this change,cargo update
no longer tries to update them.Additional Info
Replaces:
Hopefully
cargo udeps
doesn't fire due to these deps not being used directly 🙏 . From memory I think this case should be fine.