Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update without rust_eth_kzg #6848

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Update cargo dependencies while keeping rust_eth_kzg pinned to 0.5.1 due to the regression described in:

The changes from that PR were not sufficient to actually pin the dependencies of rust_eth_kzg, because the dependencies from the workspace Cargo.toml file were not being used anywhere. To fix this, I've added them as explicit dependencies in crypto/kzg/Cargo.toml. With this change, cargo update no longer tries to update them.

Additional Info

Replaces:

Hopefully cargo udeps doesn't fire due to these deps not being used directly 🙏 . From memory I think this case should be fine.

@michaelsproul michaelsproul added ready-for-review The code is ready for review dependencies Pull requests that update a dependency file labels Jan 23, 2025
@michaelsproul michaelsproul changed the title Cargo update without rust_eth_kzg Cargo update without rust_eth_kzg Jan 23, 2025
@michaelsproul
Copy link
Member Author

Ok, this will need the MSRV bump. This is a bit naughty, because the alloy deps shouldn't be bumping MSRV on patch releases.

@michaelsproul
Copy link
Member Author

MSRV bump is fine, but I've asked about Alloy's policy here just so we know how to handle this going forward:

@michaelsproul michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Jan 29, 2025
@@ -1,4 +1,4 @@
FROM rust:1.80.0-bullseye AS builder
FROM rust:1.84.0-bullseye AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also bump the version in lcli too?

FROM rust:1.80.0-bullseye AS builder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I thought of this and then forgot to do it 🤦‍♂️

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just added a minor comment to update lcli Dockerfile as well.

Marking this as backwards-incompat due to MSRV update.

@jimmygchen jimmygchen added the backwards-incompat Backwards-incompatible API change label Jan 30, 2025
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2025
@michaelsproul
Copy link
Member Author

Updated!

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 30, 2025
mergify bot added a commit that referenced this pull request Jan 30, 2025
@mergify mergify bot merged commit d47b3e3 into sigp:unstable Jan 30, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants