Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data loading #21

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Data loading #21

merged 1 commit into from
Aug 27, 2024

Conversation

ksew1
Copy link
Member

@ksew1 ksew1 commented Aug 25, 2024 •
edited
Loading

Closes #9

This was referenced Aug 25, 2024
Merged
Merged
Merged
@ksew1 ksew1 linked an issue Aug 26, 2024 that may be closed by this pull request
Data loading #9
Closed
MaksymilianDemitraszek
MaksymilianDemitraszek suggested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand many parts of the code. Many names seem off. If you explain to me what the stuctures/functions represent I am happy to help you figure out the better names.

I don't understand the purpose of the mappings module. It probably should be inside of the data module?

crates/cairo-coverage/src/types.rs Show resolved Hide resolved
crates/cairo-coverage/src/types.rs Show resolved Hide resolved
crates/cairo-coverage/src/input/data_loader/types.rs Show resolved Hide resolved
crates/cairo-coverage/src/input/data_loader/types.rs Show resolved Hide resolved
crates/cairo-coverage/src/input/mappings/sierra_ids.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/mappings/sierra_ids.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/mappings/sierra_ids.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/mappings/statement_map.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/data_loader/deserialize.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/data_loader/deserialize.rs Outdated Show resolved Hide resolved
@ksew1 ksew1 force-pushed the spr/main/937b4f8c branch 3 times, most recently from f750e8b to f396080 Compare August 26, 2024 20:55
@ksew1 ksew1 force-pushed the spr/main/937b4f8c branch 4 times, most recently from bf5cdce to 5f7ff0d Compare August 27, 2024 12:56
MaksymilianDemitraszek
MaksymilianDemitraszek approved these changes Aug 27, 2024
View reviewed changes
crates/cairo-coverage/src/input/data.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/statements_map.rs Outdated Show resolved Hide resolved
@ksew1
Data loading
36d90d0 
commit-id:937b4f8c
@ksew1 ksew1 force-pushed the spr/main/937b4f8c branch from 5f7ff0d to 36d90d0 Compare August 27, 2024 22:17
@ksew1 ksew1 merged commit f6bb0e7 into main Aug 27, 2024
10 checks passed
@ksew1 ksew1 deleted the spr/main/937b4f8c branch September 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymilianDemitraszek MaksymilianDemitraszek MaksymilianDemitraszek approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data loading
2 participants
@ksew1 @MaksymilianDemitraszek