Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loading #9

Closed
MaksymilianDemitraszek opened this issue Aug 6, 2024 · 0 comments · Fixed by #21
Closed

Data loading #9

MaksymilianDemitraszek opened this issue Aug 6, 2024 · 0 comments · Fixed by #21
Assignees

Comments

@MaksymilianDemitraszek
Copy link
Contributor

MaksymilianDemitraszek commented Aug 6, 2024

We need to add structs and utilities to load necessary data, it includes:

  • profiler trace data (we should use profiler's library)
  • sierra code
  • sierra debug info - functions and lines annotations

It should be simillar to what profiler does: https://github.com/software-mansion/cairo-profiler/blob/1910c74220e203d625e02e890adce70b3992380e/crates/cairo-profiler/src/main.rs#L59
But we also need to load statements -> lines from annotations (profiler loads only functions).

We should add an example data and write a test loading it, based on this PR: software-mansion/scarb#1506

The PR should not process the data in any way, just load it and test the loading utilities + provide the test data.

@ksew1 ksew1 mentioned this issue Aug 8, 2024
@ksew1 ksew1 linked a pull request Aug 26, 2024 that will close this issue
@ksew1 ksew1 mentioned this issue Aug 27, 2024
@ksew1 ksew1 closed this as completed in #21 Aug 27, 2024
@ksew1 ksew1 closed this as completed in f6bb0e7 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants