Don't mask GoogleTest / GoogleBenchmark in vendorpull.mask
#1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 2153b13 | Previous: e60f27b | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.282339472717303 ns/iter |
2.213925226090463 ns/iter |
1.03 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.2043408285347525 ns/iter |
2.181037197158423 ns/iter |
1.01 |
Regex_Period_Asterisk |
2.2012295323356263 ns/iter |
2.1838570358515845 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
2.199265752902993 ns/iter |
2.1806552270113575 ns/iter |
1.01 |
Regex_Period_Plus |
2.8308330601494536 ns/iter |
2.8013772412871996 ns/iter |
1.01 |
Regex_Period |
2.7048051278289127 ns/iter |
2.7992112849010296 ns/iter |
0.97 |
Regex_Caret_Period_Plus_Dollar |
2.487008599052802 ns/iter |
2.7995535694148073 ns/iter |
0.89 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.487431923948381 ns/iter |
2.798196719825692 ns/iter |
0.89 |
Regex_Caret_Period_Asterisk_Dollar |
2.4856103259206113 ns/iter |
3.5122415935290237 ns/iter |
0.71 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.4854016540087946 ns/iter |
3.4220224507270873 ns/iter |
0.73 |
Regex_Caret_X_Hyphen |
12.541843200413572 ns/iter |
12.524851465543238 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
81.76332571226354 ns/iter |
81.15828879330634 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
6.833225208259966 ns/iter |
5.886704660352123 ns/iter |
1.16 |
Regex_Caret_Period_Range_Dollar |
4.038796547395094 ns/iter |
3.110154209937324 ns/iter |
1.30 |
Regex_Nested_Backtrack |
491.78355119119095 ns/iter |
514.2197610057345 ns/iter |
0.96 |
JSON_Array_Of_Objects_Unique |
410.55089766393274 ns/iter |
406.7240178021519 ns/iter |
1.01 |
JSON_Parse_1 |
30427.979340277547 ns/iter |
30137.980592969474 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.4845441933667 ns/iter |
58.44894358963791 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
149.9559108890023 ns/iter |
150.57649987574268 ns/iter |
1.00 |
JSON_String_Equal/10 |
5.918044182125283 ns/iter |
7.531612315044244 ns/iter |
0.79 |
JSON_String_Equal/100 |
6.543536761283089 ns/iter |
8.105113996390571 ns/iter |
0.81 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9350984092287458 ns/iter |
0.9350042688190131 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.603515388489729 ns/iter |
10.256431439711774 ns/iter |
1.42 |
JSON_String_Fast_Hash/10 |
2.4867702145647343 ns/iter |
2.4869064098913993 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.4870635727506394 ns/iter |
2.4869279909690767 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.691949615023481 ns/iter |
2.1784597715128995 ns/iter |
1.24 |
JSON_String_Key_Hash/100 |
1.8721596511365761 ns/iter |
1.8686740860697009 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.738988847486228 ns/iter |
3.734234533427924 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7338432826329604 ns/iter |
3.7335782892609406 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.7343070564145218 ns/iter |
3.7323317212901315 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.28170034125205 ns/iter |
45.30695616122521 ns/iter |
0.98 |
Pointer_Object_Try_Traverse |
52.29745409903909 ns/iter |
52.29773854759332 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
307.9354664180411 ns/iter |
391.5971329210413 ns/iter |
0.79 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 2153b13 | Previous: e60f27b | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.7062282332952305 ns/iter |
1.8242165228208704 ns/iter |
0.94 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.6710524554564778 ns/iter |
1.8071244832641369 ns/iter |
0.92 |
Regex_Period_Asterisk |
1.9447699259056421 ns/iter |
1.735450378114346 ns/iter |
1.12 |
Regex_Group_Period_Asterisk_Group |
1.8088095363353403 ns/iter |
1.798036572567491 ns/iter |
1.01 |
Regex_Period_Plus |
2.1953572582431744 ns/iter |
2.0257231143170777 ns/iter |
1.08 |
Regex_Period |
2.1431583161567405 ns/iter |
2.045928794756194 ns/iter |
1.05 |
Regex_Caret_Period_Plus_Dollar |
2.097199372389368 ns/iter |
2.0842950053031917 ns/iter |
1.01 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.130016187363861 ns/iter |
2.049473310956992 ns/iter |
1.04 |
Regex_Caret_Period_Asterisk_Dollar |
1.835630766553997 ns/iter |
1.7868054695137836 ns/iter |
1.03 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.0881650712742963 ns/iter |
1.762858853969241 ns/iter |
1.18 |
Regex_Caret_X_Hyphen |
8.623196533369983 ns/iter |
7.3395972261961795 ns/iter |
1.17 |
Regex_Period_Md_Dollar |
91.44998598236634 ns/iter |
80.71804340548816 ns/iter |
1.13 |
Regex_Caret_Slash_Period_Asterisk |
6.505774635899936 ns/iter |
5.491992189331436 ns/iter |
1.18 |
Regex_Caret_Period_Range_Dollar |
2.6133713240618417 ns/iter |
2.7534142993275497 ns/iter |
0.95 |
Regex_Nested_Backtrack |
885.3643866429576 ns/iter |
865.3547910089281 ns/iter |
1.02 |
JSON_Array_Of_Objects_Unique |
373.11056347325194 ns/iter |
378.69842558974665 ns/iter |
0.99 |
JSON_Parse_1 |
25532.6917107227 ns/iter |
25337.798925894454 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
53.39302730281285 ns/iter |
56.66312040076961 ns/iter |
0.94 |
JSON_Equality_Helm_Chart_Lock |
137.41802300530068 ns/iter |
139.67001185273747 ns/iter |
0.98 |
JSON_String_Equal/10 |
8.38933399886708 ns/iter |
8.927895113010626 ns/iter |
0.94 |
JSON_String_Equal/100 |
6.694877478724103 ns/iter |
6.8756702167692865 ns/iter |
0.97 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.3520817573664846 ns/iter |
0.34494074028389493 ns/iter |
1.02 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.090709816800209 ns/iter |
3.350458395797417 ns/iter |
0.92 |
JSON_String_Fast_Hash/10 |
1.6999621854415172 ns/iter |
1.876340101022688 ns/iter |
0.91 |
JSON_String_Fast_Hash/100 |
2.1871612141082233 ns/iter |
2.60608730474807 ns/iter |
0.84 |
JSON_String_Key_Hash/10 |
1.3659100492367844 ns/iter |
1.5560566815828054 ns/iter |
0.88 |
JSON_String_Key_Hash/100 |
1.2888755668560816 ns/iter |
1.6971567567564623 ns/iter |
0.76 |
JSON_Object_Defines_Miss_Same_Length |
2.3371393554341036 ns/iter |
2.5451271965469315 ns/iter |
0.92 |
JSON_Object_Defines_Miss_Too_Small |
2.449249561488664 ns/iter |
2.5716615884515472 ns/iter |
0.95 |
JSON_Object_Defines_Miss_Too_Large |
2.4045171144779727 ns/iter |
2.6662948035056893 ns/iter |
0.90 |
Pointer_Object_Traverse |
16.143717320935618 ns/iter |
17.396833773630902 ns/iter |
0.93 |
Pointer_Object_Try_Traverse |
25.523601760359966 ns/iter |
27.46585355812475 ns/iter |
0.93 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
177.29130459613106 ns/iter |
213.72781054799083 ns/iter |
0.83 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 2153b13 | Previous: e60f27b | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
6.995493303570807 ns/iter |
6.876421874998531 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.05006559352634 ns/iter |
7.047133897111712 ns/iter |
1.00 |
Regex_Period_Asterisk |
6.849185267857446 ns/iter |
7.0031629464268565 ns/iter |
0.98 |
Regex_Group_Period_Asterisk_Group |
7.023097098213884 ns/iter |
7.0481821428570255 ns/iter |
1.00 |
Regex_Period_Plus |
7.364724330357777 ns/iter |
7.361560267857519 ns/iter |
1.00 |
Regex_Period |
7.679601562499932 ns/iter |
7.4069107142880695 ns/iter |
1.04 |
Regex_Caret_Period_Plus_Dollar |
7.4532533482152274 ns/iter |
7.4546705024322 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.13155982142918 ns/iter |
7.24530245535807 ns/iter |
0.98 |
Regex_Caret_Period_Asterisk_Dollar |
7.124313616071783 ns/iter |
6.822015624999368 ns/iter |
1.04 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
6.848578094426304 ns/iter |
7.266694196429921 ns/iter |
0.94 |
Regex_Caret_X_Hyphen |
11.730314285713918 ns/iter |
12.004501562500991 ns/iter |
0.98 |
Regex_Period_Md_Dollar |
147.32991306561507 ns/iter |
147.62312499999754 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
10.755275000000049 ns/iter |
10.79574821428407 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
7.530424107142458 ns/iter |
7.603155769629633 ns/iter |
0.99 |
Regex_Nested_Backtrack |
651.6862999999375 ns/iter |
616.6310999999496 ns/iter |
1.06 |
JSON_Array_Of_Objects_Unique |
447.7343108747262 ns/iter |
446.4995455805303 ns/iter |
1.00 |
JSON_Parse_1 |
80031.27232142202 ns/iter |
81603.00223212554 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
69.06922321428104 ns/iter |
63.141892857154446 ns/iter |
1.09 |
JSON_Equality_Helm_Chart_Lock |
200.4909531030788 ns/iter |
194.2644816307439 ns/iter |
1.03 |
JSON_String_Equal/10 |
9.607955314250374 ns/iter |
9.615712457075228 ns/iter |
1.00 |
JSON_String_Equal/100 |
9.972696874999798 ns/iter |
9.98126718750214 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.1699512922210658 ns/iter |
2.169859687499809 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.600082589285739 ns/iter |
14.60868542585388 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
3.7259191004897514 ns/iter |
3.7231478504949362 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.714561957652329 ns/iter |
3.7235517790657204 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
7.732119419642406 ns/iter |
7.54683816964276 ns/iter |
1.02 |
JSON_String_Key_Hash/100 |
4.0299535786248795 ns/iter |
4.026340855403697 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.7192221362154245 ns/iter |
3.7241374048946088 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7241598147782984 ns/iter |
3.7264237433467895 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
4.962867000000415 ns/iter |
4.963496000000305 ns/iter |
1.00 |
Pointer_Object_Traverse |
53.404860000000554 ns/iter |
53.57694642857577 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
68.14488839286577 ns/iter |
68.14140178570531 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
184.2857843112396 ns/iter |
176.68225684660567 ns/iter |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 2153b13 | Previous: e60f27b | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
50.18930873067868 ns/iter |
49.31412741519117 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
26.485415383634468 ns/iter |
26.493728008211963 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
145.29746760960353 ns/iter |
144.2175294806374 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
421.7808211400239 ns/iter |
428.78729394696563 ns/iter |
0.98 |
JSON_Parse_1 |
33589.297992892745 ns/iter |
34333.00294999813 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
68.73141777492363 ns/iter |
68.81026914162385 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
141.70960192692291 ns/iter |
143.22520285254782 ns/iter |
0.99 |
JSON_String_Equal/10 |
6.071729622939375 ns/iter |
5.990423469557301 ns/iter |
1.01 |
JSON_String_Equal/100 |
6.609967930091467 ns/iter |
6.609808201871795 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6249377533286723 ns/iter |
0.6230305409269699 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.287637644645272 ns/iter |
14.289300989045822 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9330649535343815 ns/iter |
0.9346264279980722 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9332757150330665 ns/iter |
0.9335926060989521 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.7122817067961509 ns/iter |
1.7115423561122542 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
2.022480121844879 ns/iter |
2.025010836133449 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.1096810944876165 ns/iter |
3.1782172921602547 ns/iter |
0.98 |
JSON_Object_Defines_Miss_Too_Small |
2.7975729833372704 ns/iter |
2.802002909304542 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
2.4880282831183034 ns/iter |
2.495172297435875 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.7986012509390408 ns/iter |
2.7964785591211343 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.797312844106045 ns/iter |
2.7955635717385388 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.797391426186817 ns/iter |
2.796961122351019 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.799342042857163 ns/iter |
2.795339696542911 ns/iter |
1.00 |
Regex_Period_Plus |
3.4215062159946865 ns/iter |
3.4194395724105084 ns/iter |
1.00 |
Regex_Period |
3.41882753006512 ns/iter |
3.418229465412014 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.4215905492454586 ns/iter |
3.4192494775455247 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.417682454425679 ns/iter |
3.4179826063742453 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
4.0389352387703905 ns/iter |
4.042433576038248 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.124916221711647 ns/iter |
4.042587514044923 ns/iter |
1.02 |
Regex_Caret_X_Hyphen |
12.428373983616954 ns/iter |
13.047950102441307 ns/iter |
0.95 |
Regex_Period_Md_Dollar |
93.51011600487166 ns/iter |
95.57435143918502 ns/iter |
0.98 |
Regex_Caret_Slash_Period_Asterisk |
7.457246227183756 ns/iter |
7.456748889371513 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.3552518580121475 ns/iter |
4.3533114657410765 ns/iter |
1.00 |
Regex_Nested_Backtrack |
827.7658102778513 ns/iter |
826.7532730032326 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: 2153b13 | Previous: e60f27b | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.166959580842134 ns/iter |
2.2487961818934705 ns/iter |
0.96 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.4331083126605018 ns/iter |
2.516705552352797 ns/iter |
0.97 |
Regex_Period_Asterisk |
2.258520628942695 ns/iter |
2.387222261194031 ns/iter |
0.95 |
Regex_Group_Period_Asterisk_Group |
2.379780729754043 ns/iter |
2.190227600803567 ns/iter |
1.09 |
Regex_Period_Plus |
1.8107538546605517 ns/iter |
2.2394669972431194 ns/iter |
0.81 |
Regex_Period |
2.160840587351895 ns/iter |
1.9253074684965739 ns/iter |
1.12 |
Regex_Caret_Period_Plus_Dollar |
1.900424810600911 ns/iter |
1.9222190270457562 ns/iter |
0.99 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.8240577466723837 ns/iter |
1.940908391975756 ns/iter |
1.46 |
Regex_Caret_Period_Asterisk_Dollar |
2.412694400023534 ns/iter |
2.113554539090945 ns/iter |
1.14 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.094740563875337 ns/iter |
2.187785115701548 ns/iter |
0.96 |
Regex_Caret_X_Hyphen |
6.4354067261333645 ns/iter |
7.452425192592184 ns/iter |
0.86 |
Regex_Period_Md_Dollar |
82.52813783348827 ns/iter |
92.68417836874725 ns/iter |
0.89 |
Regex_Caret_Slash_Period_Asterisk |
5.2866200116551445 ns/iter |
5.278536045466146 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
2.2685267090811907 ns/iter |
2.141641506350633 ns/iter |
1.06 |
Regex_Nested_Backtrack |
973.9493464836875 ns/iter |
955.079115452416 ns/iter |
1.02 |
JSON_Array_Of_Objects_Unique |
266.511560012881 ns/iter |
242.8818076706509 ns/iter |
1.10 |
JSON_Parse_1 |
26185.036274506157 ns/iter |
25472.502016101742 ns/iter |
1.03 |
JSON_Fast_Hash_Helm_Chart_Lock |
25.76870949208845 ns/iter |
25.75664568496893 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
126.83542139931781 ns/iter |
138.83093338973353 ns/iter |
0.91 |
JSON_String_Equal/10 |
6.716484367257441 ns/iter |
5.8465077414553415 ns/iter |
1.15 |
JSON_String_Equal/100 |
5.931682961488495 ns/iter |
5.561806799409691 ns/iter |
1.07 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.1483591988316937 ns/iter |
1.0201777796095854 ns/iter |
1.13 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
4.422372225476446 ns/iter |
3.802094421672884 ns/iter |
1.16 |
JSON_String_Fast_Hash/10 |
2.1991266589219247 ns/iter |
2.130183921695696 ns/iter |
1.03 |
JSON_String_Fast_Hash/100 |
2.3027629021150924 ns/iter |
2.090227355169176 ns/iter |
1.10 |
JSON_String_Key_Hash/10 |
1.5516718661778008 ns/iter |
1.54955924231847 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
2.321355011388456 ns/iter |
2.0797455593968253 ns/iter |
1.12 |
JSON_Object_Defines_Miss_Same_Length |
1.9034037914626731 ns/iter |
1.9280327446398697 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Too_Small |
2.1715831622905366 ns/iter |
2.361399295838576 ns/iter |
0.92 |
JSON_Object_Defines_Miss_Too_Large |
2.1848058552533827 ns/iter |
2.141456582340349 ns/iter |
1.02 |
Pointer_Object_Traverse |
73.81519876749866 ns/iter |
73.30933705099729 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
47.887668096107056 ns/iter |
47.097571961214754 ns/iter |
1.02 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
180.7051290644294 ns/iter |
205.45167434969846 ns/iter |
0.88 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]