feat: i18n with angular localize #1787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the PR #1786 is merged first this one would require an update of localize to "13.0.1" |
|
@klopfdreh Thank you for the contribution! |
|
I adjusted the command to extract i18n a bit: |
claudiahub
force-pushed
the
feat/i18n
branch
from
67c8906 to
4445297
Compare
|
Force-Push on my Repository? 😨 Anyway feel free I didn't restrict it. 😄 |
|
Hi @klopfdreh,
|
|
Great to see! 😃 - if I can help further more just ping me! |
klopfdreh
commented
Dec 17, 2021
| @@ -9,10 +9,15 @@ | |||
| "projectType": "application", | |||
| "prefix": "app", | |||
| "i18n": { | |||
| "sourceLocale": "en-US", | |||
| "sourceLocale": { | |||
| "code": "en", | |||
There was a problem hiding this comment.
Nice to see that you can apply "en" for source locale - I just tried that, but without a JSON object and it failed. Good to see that it works, now. 👍
Merged
|
Close in favor of #1794 (easier maintenance, dynamic translation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a complete i18n integration for spring-cloud-dataflow-ui. (at least I hope I caught every translation required occurrence 😁 )
I also provide a complete translation into german language with this PR.
Screenshot:
Some important commands:
ng extract-i18n --format=xlf2- extract all translations into a messages.xlf which should be renamed into messages.en.xlf and moved intosrc/locale/. All other language files should be compared against this one.ng serve --open -c=de- runs the ui with a given configuration in this case de (German)I also adjusted some of the script commands.
This PR addresses: #701