Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n with angular localize #1787

Closed
wants to merge 9 commits into from
Closed

feat: i18n with angular localize #1787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9436d1e
Rebased feat: i18n to main
klopfdreh Dec 2, 2021
de1f3a5
fix: end tag of builder translation
klopfdreh Dec 7, 2021
e14c4ee
fix: sourceLocale and script changes
klopfdreh Dec 8, 2021
4445297
fix: sourceLocale set to en-US
klopfdreh Dec 8, 2021
a4c68d0
Prettify code after rebase
claudiahub Dec 14, 2021
22ee38b
Upgrade localize package to v13.1.0
claudiahub Dec 14, 2021
77c3267
Done dropdown language selector and connected store actions
claudiahub Dec 14, 2021
e991d59
Update language list having default on english (en)
claudiahub Dec 14, 2021
7cfe6cd
Fix maven build
oodamien Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 17 additions & 33 deletions ui/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@
"projectType": "application",
"prefix": "app",
"i18n": {
"sourceLocale": "en-US",
"sourceLocale": {
"code": "en",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that you can apply "en" for source locale - I just tried that, but without a JSON object and it failed. Good to see that it works, now. 👍

"baseHref": ""
},
"locales": {
"en": "src/locale/messages.en.xlf",
"de": "src/locale/messages.de.xlf"
"de": {
"baseHref": "",
"translation": "src/locale/messages.de.xlf"
}
}
},
"schematics": {
Expand All @@ -34,16 +39,8 @@
"inlineCritical": false
}
},
"assets": [
"src/favicon.ico",
"src/assets",
"src/logout-success-oauth.html"
],
"styles": [
"node_modules/@clr/icons/clr-icons.css",
"node_modules/@clr/ui/clr-ui.css",
"src/styles.scss"
],
"assets": ["src/favicon.ico", "src/assets", "src/logout-success-oauth.html"],
"styles": ["node_modules/@clr/icons/clr-icons.css", "node_modules/@clr/ui/clr-ui.css", "src/styles.scss"],
"scripts": [
"node_modules/@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js",
"node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js",
Expand Down Expand Up @@ -77,7 +74,9 @@
"extractLicenses": false,
"buildOptimizer": false,
"sourceMap": true,
"namedChunks": true
"namedChunks": true,
"i18nMissingTranslation": "error",
"deleteOutputPath": false
},
"configurations": {
"production": {
Expand Down Expand Up @@ -105,9 +104,6 @@
"vendorChunk": false,
"buildOptimizer": true
},
"en": {
"localize": ["en"]
},
"de": {
"localize": ["de"]
}
Expand Down Expand Up @@ -145,24 +141,15 @@
"polyfills": "src/polyfills.ts",
"tsConfig": "src/tsconfig.spec.json",
"karmaConfig": "src/karma.conf.js",
"styles": [
"src/styles.scss"
],
"styles": ["src/styles.scss"],
"scripts": [],
"assets": [
"src/favicon.ico",
"src/assets",
"src/logout-success-oauth.html"
]
"assets": ["src/favicon.ico", "src/assets", "src/logout-success-oauth.html"]
}
},
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": [
"src/app/**/*.ts",
"src/app/**/*.html"
]
"lintFilePatterns": ["src/app/**/*.ts", "src/app/**/*.html"]
}
}
}
Expand All @@ -186,10 +173,7 @@
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": [
"e2e/src/**/*.ts",
"e2e/src/**/*.html"
]
"lintFilePatterns": ["e2e/src/**/*.ts", "e2e/src/**/*.html"]
}
}
}
Expand Down
Loading