-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added C implementation for @stdlib/math/base/special/fibonacci-index
#2673
Conversation
@vivek-anand-singh This PR cannot be accepted as is.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow conventions elsewhere in the project. For submitting PRs, please see recent merged PRs for an idea of what is expected. Given that the intent was to add @stdlib/math/base/special/fibonacci-index
, I suggest examining the PRs linked to #649.
As #1756 has already been implemented in #2272, I will go ahead and close this PR. @vivek-anand-singh I suggest finding another issue to work on, perhaps asking on #649 where work is being tracked. |
@kgryte, I deeply apologize for the mistakes in my PR. For the first issue, I previously raised a PR on the cusome-by branch (PR #2661). When the second issue got assigned to me, I mistakenly assumed I was on the main branch and didn't switch branches. This oversight affected the PR, and I take full responsibility for it. For the second issue, I overlooked the base folder, which I fully accept was my fault. I should have been more thorough in reviewing the project structure. I sincerely apologize for any inconvenience caused. I genuinely want to learn from this experience and contribute positively to the organization in the future. I'm truly sorry for the oversight and would be grateful for another opportunity to make things right. |
Resolves #1756
Description
This pull request:
This adds the native C implementation for
@stdlib/math/base/special/fibonacci-index.
Related Issues
This pull request:
@stdlib/math/base/special/fibonacci-index
#1756@stdlib/math/base/special/fibonacci-index
#1756Questions
Other
No.
Checklist
@stdlib-js/reviewers