Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PLLSrc enum not matching capitalisation conventions #131

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix PLLSrc enum not matching capitalisation conventions #131

merged 1 commit into from
Aug 5, 2024

Conversation

liamkinne
Copy link
Contributor

PLLSrc -> PllSrc

@liamkinne
Copy link
Contributor Author

@usbalbin not sure if you have write permissions yet, but here's another PR to look at. Thanks.

@usbalbin
Copy link
Contributor

usbalbin commented Aug 3, 2024 •
edited
Loading

@usbalbin not sure if you have write permissions yet, but here's another PR to look at. Thanks.

I do not, as far as I know.

LGTM! :)

However I would (unless this does that) prefer to fix the CI errors first if possible

@liamkinne
Copy link
Contributor Author

@usbalbin the CI errors are all to do with typos which I've fixed in #128. Still waiting on getting that merged as well.

@usbalbin
Copy link
Contributor

usbalbin commented Aug 4, 2024 •
edited
Loading

Great!

However there are, as far as I can tell, still some clippy warnings left for #128.

@liamkinne liamkinne force-pushed the fix-pll-src-capitalisation branch from 2ba7c0f to 417c465 Compare August 5, 2024 09:53
@liamkinne
Copy link
Contributor Author

Now passes CI @usbalbin

usbalbin
usbalbin approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@usbalbin usbalbin merged commit 7732840 into stm32-rs:main Aug 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usbalbin usbalbin usbalbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamkinne @usbalbin