Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests to periphery #79

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

sebsadface
Copy link
Member

@sebsadface sebsadface commented Sep 27, 2024

Description

This PR introduces integration tests for the periphery contracts. These tests are intended to be run against a live deployment of the PoC periphery contracts, sending real transactions to the blockchain. The new integration tests include:

  • DerivativeIntegration
  • GroupingIntegration
  • LicenseAttachmentIntegration
  • RegistrationIntegration
  • RoyaltyIntegration

Additional Changes:

  • Added documentation outlining how to run these integration tests (details see /test/integration/README.md).
  • Corrected several typos in existing code comments.

Testing

All existing tests have passed, and the newly added integration tests have been run locally to ensure everything works as expected. For detailed test output and transaction hashes, refer to: TestOutput.md.

Related Issue

Notes

Please note that the RoyaltyIntegration test currently cannot be executed against the production PoC core protocol due to limitations related to snapshot intervals.

@sebsadface sebsadface changed the title Integ test test: add integration tests to periphery Sep 27, 2024
@kingster-will
Copy link

LGTM!

@sebsadface sebsadface merged commit eaa87db into storyprotocol:main Sep 27, 2024
3 checks passed
@sebsadface sebsadface deleted the integ-test branch October 16, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Integration Tests to SPG
2 participants