fix: disable region check for Azure CloudEnvironment #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsxu
reviewed
Dec 4, 2024
| @@ -90,7 +90,7 @@ func resourceCloudEnvironment() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Description: descriptions["region"], | |||
| ValidateFunc: validateRegion, | |||
| ValidateFunc: validateNotBlank, | |||
There was a problem hiding this comment.
But it's useful for AWS and GCP, can we create separate rule for Azure?
There was a problem hiding this comment.
I've updated this PR to add separate validation rules: https://github.com/streamnative/terraform-provider-streamnative/pull/69/files#diff-c02472e6df317b435706b287c76b320eea0b27f53a2bc8c447058fcc2be79cf6R227
maxsxu
approved these changes
Dec 7, 2024
maxsxu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #66
Azure needs to use ResourceGroup name in the region parameter, so cannot validate it