Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable region check for Azure CloudEnvironment #69

Merged
merged 4 commits into from
Dec 7, 2024
Merged

fix: disable region check for Azure CloudEnvironment #69

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1aa13b9
Disable region check
jiangpengcheng Nov 5, 2024
02dad0e
Merge branch 'main' into do_not_check_region_for_azure_cloud_environment
maxsxu Dec 3, 2024
af6e5bf
Merge branch 'main' into do_not_check_region_for_azure_cloud_environment
maxsxu Dec 7, 2024
1fa1e2e
Only check aws and gcp region
maxsxu Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloud/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func init() {
"cloud_connection_name": "Name of the cloud connection",
"environment_type": "Type of the cloud environment, either: dev, test, staging, production, acc, qa or poc",
"cloud_environment_name": "Name of the cloud environment",
"region": "The region of the cloud environment",
"region": "The region of the cloud environment, for Azure, it should be the resource group name",
"zone": "The zone of the cloud environment, the underlying infrastructure will only be created in this zone if configured",
"default_gateway": "The default gateway of the cloud environment",
"apikey_name": "The name of the api key",
Expand Down
2 changes: 1 addition & 1 deletion cloud/resource_cloud_environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func resourceCloudEnvironment() *schema.Resource {
Type: schema.TypeString,
Required: true,
Description: descriptions["region"],
ValidateFunc: validateRegion,
ValidateFunc: validateNotBlank,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's useful for AWS and GCP, can we create separate rule for Azure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this PR to add separate validation rules: https://github.com/streamnative/terraform-provider-streamnative/pull/69/files#diff-c02472e6df317b435706b287c76b320eea0b27f53a2bc8c447058fcc2be79cf6R227

},
"zone": {
Type: schema.TypeString,
Expand Down
Loading