Mix HCPB Materials using fusion-materials-db #26
Conversation
|
I think that @katielygre has proposed one or two more layers of subdirectory for these examples in #27 - I think it would be good to match her approach. |
Yes, we decided today to have multiple subdirectories for our examples, but we were a little concerned that making the same subdirectories within separate PRs might lead to a merge conflict. If that's not the case I'll go ahead and match the structure in #27. |
|
Git only really cares about files for merge conflicts, so both making directories should be fine. |
…ple/HCPB_Build_Dict.py
…xample/HCPB_Mix_Materials.py
…_radial_build_example/openmc_Materials_Object_from_json.py
| def parse_args(): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('--HCPB_YAML', default = 'HCPB_YAML.yaml', help="Path (str) to YAML containing inputs for HCPB build dictionary & mix materials") | ||
| args = parser.parse_args() | ||
| return args | ||
|
|
||
| def read_yaml(args): | ||
| with open(args.HCPB_YAML, 'r') as hcpb_yaml: | ||
| yaml_inputs = yaml.safe_load(hcpb_yaml) | ||
| return yaml_inputs |
There was a problem hiding this comment.
These functions can be defined outside of main at the global scope. I'm not sure I have a clear reason for this other than reduced complexity. I think it is rare to have functions defined within other functions, and usually serves a very specific purpose.
| yaml_inputs['geom']['minor_radius_z'], | ||
| yaml_inputs['geom']['minor_radius_xy'], | ||
| build_dict) | ||
| plot_radial_build(yaml_inputs['filenames']['radial_plot_name'], build_dict) |
There was a problem hiding this comment.
Perhaps this can be an option governed by something in argparse
…les/dcll_hcpb_examples/hcpb_radial_build_example/HCPB_Build_Dict.py
…amples/dcll_hcpb_examples/hcpb_radial_build_example/HCPB_Mix_Materials.py
…dcll_hcpb_examples/hcpb_radial_build_example/HCPB_YAML.yaml
fixes #18, #21, #23, #25