Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mix HCPB Materials using fusion-materials-db #26
Mix HCPB Materials using fusion-materials-db #26
Changes from 22 commits
1ca2910
722423d
1ae265d
13f0893
6915e51
c98cb30
c56c602
dade192
cc9a60e
8583ffb
6c5656e
ed9ec4e
42ba0da
a1982fc
cf81643
c17c675
aff00d7
ff03d56
adc3148
34fe50d
e3b9347
c9dd690
ba95423
6f6f9de
24ebcc4
23ef806
7131c0e
9552122
20a1de9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions can be defined outside of
main
at the global scope. I'm not sure I have a clear reason for this other than reduced complexity. I think it is rare to have functions defined within other functions, and usually serves a very specific purpose.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this can be an option governed by something in argparse