Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CNN class for handling MNIST dataset and import it into main.py #82

Closed
wants to merge 9 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 20, 2023

Description

This PR adds a new CNN class in a new file called cnn.py to handle the MNIST dataset. The CNN class is designed to train a convolutional neural network on the MNIST dataset and includes methods for defining the architecture, training the model, and saving the trained model. The CNN class is properly documented with docstrings and comments.

The main.py file has been modified to import the CNN class from cnn.py and use it for training the model on the MNIST dataset. The existing code for loading the MNIST dataset and preprocessing it has been reused in the CNN class. After training, the trained model is saved using the save_model method of the CNN class.

Summary of Changes

  • Created a new file called cnn.py in the src directory.
  • Defined a new class called CNN in cnn.py, which inherits from torch.nn.Module.
  • Implemented the init method in the CNN class to define the architecture of the CNN.
  • Implemented the forward method in the CNN class to perform the forward pass of the CNN.
  • Implemented the train method in the CNN class to train the CNN on the MNIST dataset.
  • Implemented the save_model method in the CNN class to save the trained model.
  • Added docstrings and comments to the CNN class and its methods.
  • Modified main.py to import the CNN class from cnn.py.
  • Replaced the existing model definition in main.py with an instance of the CNN class.
  • Replaced the existing training code in main.py with a call to the train method of the CNN instance.
  • Updated comments and docstrings in main.py to reflect the changes.

Please review and merge this PR. Thank you!

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 20, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/cnn.py
  • Rollback changes to src/cnn.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot closed this Oct 23, 2023
@sweep-nightly sweep-nightly bot deleted the sweep/add-cnn-class_3 branch October 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
0 participants