Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Init Containers and Volume Mounts #450

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

askoriy
Copy link
Contributor

@askoriy askoriy commented Jan 4, 2024

What was changed

Add the option co configure additional init containers and volume mounts

Why?

In our case to get certificates from Vault and mount as files

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@askoriy askoriy requested review from a team as code owners January 4, 2024 17:28
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

templates/admintools-deployment.yaml Outdated Show resolved Hide resolved
templates/admintools-deployment.yaml Outdated Show resolved Hide resolved
templates/admintools-deployment.yaml Outdated Show resolved Hide resolved
@robholland robholland added the needs revision Team has requested some changes label Jun 8, 2024
@askoriy askoriy requested a review from a team as a code owner September 11, 2024 04:01
@askoriy askoriy requested a review from robholland September 12, 2024 13:07
@enricojonas
Copy link

enricojonas commented Dec 2, 2024

@robholland @askoriy can we get this merged? We need this functionality.

We would also like to propagate the server init containers to the server job. That way, if you use any proxy for example, it can be used during DB creation, schema setup and update.

        {{- if $.Values.server.initContainers }}
        {{- toYaml $.Values.server.initContainers | nindent 8 }}
        {{- end }}

Let me know if you can include it or if you want me to push a commit to this branch.

robholland added a commit that referenced this pull request Dec 4, 2024
@robholland robholland mentioned this pull request Dec 4, 2024
@robholland robholland merged commit 72644fe into temporalio:main Dec 4, 2024
3 checks passed
robholland added a commit that referenced this pull request Dec 10, 2024
* Add unit tests for #450.
asproul pushed a commit to asproul/helm-charts that referenced this pull request Dec 16, 2024
asproul pushed a commit to asproul/helm-charts that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs revision Team has requested some changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants