-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional Init Containers and Volume Mounts #450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robholland
requested changes
Jun 8, 2024
@robholland @askoriy can we get this merged? We need this functionality. We would also like to propagate the server init containers to the server job. That way, if you use any proxy for example, it can be used during DB creation, schema setup and update.
Let me know if you can include it or if you want me to push a commit to this branch. |
robholland
added a commit
that referenced
this pull request
Dec 4, 2024
Merged
robholland
approved these changes
Dec 4, 2024
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
* Add additionalInitContainers
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
* Add unit tests for temporalio#450.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add the option co configure additional init containers and volume mounts
Why?
In our case to get certificates from Vault and mount as files
Checklist
Closes
How was this tested: