Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy 2023 files #1

Merged
merged 48 commits into from
Jan 5, 2024
Merged

Copy 2023 files #1

merged 48 commits into from
Jan 5, 2024

Conversation

fotnitfpro000
Copy link
Contributor

added files for the root directory in the repo

auscompgeek
auscompgeek requested changes Jan 4, 2024
View reviewed changes
Physics.py Outdated Show resolved Hide resolved
@james-ward
Copy link
Contributor

Without going into the specifics of the PR, the way you have laid it out is perfect. You've got a commit for each change (file added), and it's just the single piece of work.
Well done.

@james-ward
Copy link
Contributor

Is it worth copying over the .github directory so that we have some tests running? What do you think @auscompgeek @fotnitfpro000 ?

fotnitfpro000 and others added 17 commits January 5, 2024 01:05
@fotnitfpro000
updated some of the vendor libraries to beta 2024
5e54a88
@outsidermm
delete 2023 game specific imports
5f0d9f3
@outsidermm
modified to the correct navx version number
f86d4bb
@outsidermm
added necessary imports and deleted unused imports for physics.py
0f80c62
@outsidermm
deleted unused imports in physics.py
0548d1f
@outsidermm
removed physics.py for decapitalisation
8833eba
@outsidermm
added physics.py lowercased file back
94f9fa8
@outsidermm
added missing function, object creation and imports (amber deleted to…
e47b638 
…o much lines)
@outsidermm
reverted back to the full 2023 chasis using 2023 lib
3416631
@outsidermm
reverted back to the 2023 requirement to test sim before updating to …
2ef5713 
…2024
@outsidermm
deleted recovery usage as it's 2023 specific
5c0961b
@outsidermm
copied movement.py from 2023 as necessary for basic teleop function
10c9985
@outsidermm
disabled vision pose estimator usage in robot.py (since only drivebas…
e897ddc 
…e skeleton)
@outsidermm
deleted 2023-specific (balancing) methods
671729d
@outsidermm
commented out later necessary methods and imports
88c785b
@outsidermm
more delete
e6203de
@outsidermm
added movement object so now the sim actually opens without crashes
6f451f4
mlists
mlists suggested changes Jan 4, 2024
View reviewed changes
robot.py Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
robot.py Outdated Show resolved Hide resolved
auscompgeek
auscompgeek reviewed Jan 5, 2024
View reviewed changes
robot.py Outdated Show resolved Hide resolved
auscompgeek
auscompgeek reviewed Jan 5, 2024
View reviewed changes
robot.py Outdated Show resolved Hide resolved
auscompgeek
auscompgeek reviewed Jan 5, 2024
View reviewed changes
robot.py Outdated Show resolved Hide resolved
@auscompgeek auscompgeek requested a review from mlists January 5, 2024 04:20
@james-ward
Copy link
Contributor

Running the manual control through a state machine is an abomination and I think it should go too.

@outsidermm
Copy link
Member

Running the manual control through a state machine is an abomination and I think it should go too.

movement.py is removed, and so is the state machine; the basic drive base teleop control is now in robot.py if that's what you mean.

@james-ward
Copy link
Contributor

Looks good to me. I can't confirm it moves in the sim where I am now, but if it does, LGTM.

@outsidermm
Copy link
Member

Looks good to me. I can't confirm it moves in the sim where I am now, but if it does, LGTM.

should I try to fix the CI / mypy, I'm not sure what exactly is causing that. The robot does move in my sim.

@mlists
Copy link
Contributor

mlists commented Jan 5, 2024 •
edited
Loading

I think you are missing your __init__.pys in each folder which is causing that CI error

@outsidermm outsidermm self-requested a review January 5, 2024 07:46
@outsidermm
Copy link
Member

can you @mlists , please review and see if it looks good to merge into the main? thanks!
by adding the init.py did fix the mypy issue

@outsidermm outsidermm removed their request for review January 5, 2024 07:50
mlists
mlists approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@mlists mlists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mlists mlists merged commit d035e90 into main Jan 5, 2024
2 checks passed
@mlists mlists deleted the copy_2023_files branch January 5, 2024 08:41
@mlists mlists restored the copy_2023_files branch January 5, 2024 08:42
@mlists mlists deleted the copy_2023_files branch January 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsidermm outsidermm outsidermm left review comments

@auscompgeek auscompgeek auscompgeek approved these changes

@mlists mlists mlists approved these changes

Assignees

@outsidermm outsidermm

@fotnitfpro000 fotnitfpro000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fotnitfpro000 @james-ward @outsidermm @auscompgeek @mlists