Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock the other mechanisms when climbing #168

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Lock the other mechanisms when climbing #168

merged 6 commits into from
Mar 11, 2024

Conversation

mlists
Copy link
Contributor

@mlists mlists commented Mar 7, 2024 •
edited
Loading

closes #165

@mlists mlists force-pushed the enforce-climb-state branch from 84b607f to 2f1e588 Compare March 7, 2024 07:57
@mlists mlists requested review from auscompgeek and SebZanardo March 7, 2024 08:42
auscompgeek
auscompgeek approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we may want to improve the shooter behaviour later

SebZanardo
SebZanardo reviewed Mar 8, 2024
View reviewed changes
components/climber.py Outdated Show resolved Hide resolved
SebZanardo
SebZanardo approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@SebZanardo SebZanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

LucienMorey
LucienMorey reviewed Mar 11, 2024
View reviewed changes
components/climber.py Outdated Show resolved Hide resolved
components/climber.py Outdated Show resolved Hide resolved
@LucienMorey LucienMorey force-pushed the enforce-climb-state branch from 636819b to 0b7180a Compare March 11, 2024 09:52
@LucienMorey LucienMorey force-pushed the enforce-climb-state branch from 0b7180a to dafcc9d Compare March 11, 2024 10:17
@LucienMorey LucienMorey merged commit ec07689 into main Mar 11, 2024
6 checks passed
@LucienMorey LucienMorey deleted the enforce-climb-state branch March 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucienMorey LucienMorey LucienMorey left review comments

@SebZanardo SebZanardo SebZanardo approved these changes

@auscompgeek auscompgeek auscompgeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force the robot into a specific state before climbing
4 participants
@mlists @auscompgeek @LucienMorey @SebZanardo