Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: support build with boringcrypto to support Fips #7275

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: Close #7274

What is changed and how does it work?

ref https://go.googlesource.com/go/+/dev.boringcrypto/README.boringcrypto.md and https://go.googlesource.com/go/+/dev.boringcrypto/src/crypto/tls/fipsonly/fipsonly.go
add command in makefile to build with boringcrypto to support Fips including pd-server、pd-ctl、pd-recover

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    image
    pd-server
    image

pd-ctl
image

pd-recover
image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7275 (e4e970f) into master (86831ce) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head e4e970f differs from pull request most recent head bad5f34. Consider uploading reports for the commit bad5f34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7275      +/-   ##
==========================================
+ Coverage   74.20%   74.45%   +0.24%     
==========================================
  Files         451      450       -1     
  Lines       48863    48819      -44     
==========================================
+ Hits        36260    36346      +86     
+ Misses       9378     9271     -107     
+ Partials     3225     3202      -23     
Flag Coverage Δ
unittests 74.45% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Cabinfever_B <[email protected]>
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2023
Makefile Outdated
@@ -15,6 +15,8 @@ dev-basic: build check basic-test
BUILD_FLAGS ?=
BUILD_TAGS ?=
BUILD_CGO_ENABLED := 0
BUILD_TOOL_CGO_ENABLED := 0
BUILD_EXPERIMENT ?=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the name is too general.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for GOEXPERIMENT, can u give some suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, how about BUILD_GOEXPERIMENT

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2023
Signed-off-by: Cabinfever_B <[email protected]>
@overvenus
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e4e970f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 181fdc9 into tikv:master Nov 15, 2023
19 checks passed
@CabinfeverB CabinfeverB deleted the fips branch November 15, 2023 13:47
@overvenus overvenus added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Nov 22, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7413.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 22, 2023
ti-chi-bot bot added a commit that referenced this pull request Dec 11, 2023
…7413)

close #7274

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Yongbo Jiang <[email protected]>
Co-authored-by: Cabinfever_B <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make pd-server support FIPS
4 participants