-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: support build with boringcrypto
to support Fips
#7275
Conversation
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
+ Coverage 74.20% 74.45% +0.24%
==========================================
Files 451 450 -1
Lines 48863 48819 -44
==========================================
+ Hits 36260 36346 +86
+ Misses 9378 9271 -107
+ Partials 3225 3202 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Cabinfever_B <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Makefile
Outdated
@@ -15,6 +15,8 @@ dev-basic: build check basic-test | |||
BUILD_FLAGS ?= | |||
BUILD_TAGS ?= | |||
BUILD_CGO_ENABLED := 0 | |||
BUILD_TOOL_CGO_ENABLED := 0 | |||
BUILD_EXPERIMENT ?= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the name is too general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used for GOEXPERIMENT, can u give some suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, how about BUILD_GOEXPERIMENT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: Cabinfever_B <[email protected]>
/merge |
@overvenus: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e4e970f
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7274 Signed-off-by: ti-chi-bot <[email protected]>
…7413) close #7274 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: Cabinfever_B <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: Cabinfever_B <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #7274
What is changed and how does it work?
ref https://go.googlesource.com/go/+/dev.boringcrypto/README.boringcrypto.md and https://go.googlesource.com/go/+/dev.boringcrypto/src/crypto/tls/fipsonly/fipsonly.go
add command in makefile to build with
boringcrypto
to support Fips including pd-server、pd-ctl、pd-recoverCheck List
Tests
pd-server
pd-ctl
pd-recover
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note